Fix note block interaction causing doubled note increase

[sciwhiz12]

This PR fixes #1938 by removing the original cycle call (as was done in the pre-1.21.2 patch), which is already replicated in the event firing call.

Tested to work using same steps in linked issue; upon interaction, note state property is only increased by one value instead of two.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: fe2fc9899349c2e87f14cdc83563b61f3a75b514.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.4.82-beta-pr-1939-fix-1.21.4-GH-1938-noteblock-note-doubling
• 📦 net.neoforged:testframework:21.4.82-beta-pr-1939-fix-1.21.4-GH-1938-noteblock-note-doubling

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1939' // https://github.com/neoforged/NeoForge/pull/1939
        url 'https://prmaven.neoforged.net/NeoForge/pr1939'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1939.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1939
cd NeoForge-pr1939
curl -L https://prmaven.neoforged.net/NeoForge/pr1939/net/neoforged/neoforge/21.4.82-beta-pr-1939-fix-1.21.4-GH-1938-noteblock-note-doubling/mdk-pr1939.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[sciwhiz12]

@neoforged/bots backport 1.21.1

(note. this is a mistake.)

[neoforged-automation]

Created backport PR: #1940