Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 1.21.1: [1.21.4] Revert Registries to Frozen on Disconnect when a connection is present #1944

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

neoforged-automation[bot]
Copy link

Backport of #1934 to 1.21.1

Fixes #1932 on 1.21.1

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Feb 6, 2025

  • Publish PR to GitHub Packages

Last commit published: 254c2c095a152a1512feffb3dd23367fffb06149.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1944' // https://github.com/neoforged/NeoForge/pull/1944
        url 'https://prmaven.neoforged.net/NeoForge/pr1944'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1944.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1944
cd NeoForge-pr1944
curl -L https://prmaven.neoforged.net/NeoForge/pr1944/net/neoforged/neoforge/21.1.117-pr-1944-backport-1.21.1-1934/mdk-pr1944.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Member

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this works on 1.21.1.

@embeddedt embeddedt merged commit ca31c86 into 1.21.1 Feb 6, 2025
7 checks passed
@embeddedt embeddedt deleted the backport/1.21.1/1934 branch February 6, 2025 20:47
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants