Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Display correct relative position as used in GameTestHelper#relativePos #1949

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

ChampionAsh5357
Copy link
Contributor

Closes #1948

Fixes the /test pos command to return the relative position using the same logic applied by GameTestHelper#relativePos. This is functionally a backport of the 1.21.5 snapshots where the bug has been resolved by modifying how StructureBlockEntity#getStructurePos works.

@ChampionAsh5357 ChampionAsh5357 added vanilla bug A bug or error in the base Minecraft game 1.21.4 Targeted at Minecraft 1.21.4 labels Feb 9, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Feb 9, 2025

  • Publish PR to GitHub Packages

Last commit published: cb508e8f42fe6e8b2de438b0300e0a974ea6aee8.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1949' // https://github.com/neoforged/NeoForge/pull/1949
        url 'https://prmaven.neoforged.net/NeoForge/pr1949'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1949.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1949
cd NeoForge-pr1949
curl -L https://prmaven.neoforged.net/NeoForge/pr1949/net/neoforged/neoforge/21.4.89-beta-pr-1949-fix-i1948/mdk-pr1949.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@sciwhiz12 sciwhiz12 merged commit 83c257a into neoforged:1.21.x Feb 9, 2025
7 checks passed
@sciwhiz12

This comment has been minimized.

@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.88-beta.

@neoforged-automation
Copy link

Created backport PR: #1950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 vanilla bug A bug or error in the base Minecraft game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange offset in GameTest position
2 participants