TASK: Declare state properties in controller to be readonly #3293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3232 (comment) i mentioned that "replacing" the
$this->response
is probably not a good idea and we should disallow this via readonly. Mutating by object reference is the only way allowed.I tried to actually enforce this via real
readonly
in #3283, but it has some severe flaws:mergeIntoParent
or return.flow-development-collection/Neos.FluidAdaptor/Classes/Core/Widget/AbstractWidgetViewHelper.php
Line 241 in 465c80b
As compromise i suggest to use the read only annotation to make people aware.
Upgrade instructions
You should never replace any of the stateful properties of the action controller.
Review instructions
This pr should not be merged before targeting 9.0.
See #3232 (comment) for explanation.
TODO
readonly
be by any chance breaking??like
use Neos/Flow/Annotations/Inject as readonly