Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Prevent getPublicStaticResourceUri from crashing in cli con… #3314

Closed
wants to merge 1 commit into from
Closed

BUGFIX: Prevent getPublicStaticResourceUri from crashing in cli con… #3314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Neos.Flow/Classes/ResourceManagement/Target/FileSystemTarget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,14 @@ protected function detectResourcesBaseUri()
return $this->baseUri;
}

$httpBaseUri = (string)$this->baseUriProvider->getConfiguredBaseUriOrFallbackToCurrentRequest();
try {
$httpBaseUri = (string)$this->baseUriProvider->getConfiguredBaseUriOrFallbackToCurrentRequest();
} catch (\Neos\Flow\Http\Exception) {
// the handstand to get the request via bootstrap failed. Most likely because we are in cli context.
// to avoid an error and still allow resolving a link we return a slash wich will result in building a relative uri.
// todo find a way to configure this fallback for this use case.
$httpBaseUri = '/';
}
return $httpBaseUri . $this->baseUri;
}

Expand Down
Loading