Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Skip headers when parsing csv #4

Closed

Conversation

dgigafox
Copy link
Contributor

@dgigafox dgigafox commented Mar 1, 2022

Fix bug where headers are included when parsing the source CSV

Actual result:

iex(1)> Airports.all() |> List.first()
%Airports.Airport{
  continent: "continent",
  elevation_ft: "elevation_ft",
  gps_code: "gps_code",
  home_link: "home_link",
  iata_code: "iata_code",
  ident: "ident",
  iso_country: "iso_country",
  iso_region: "iso_region",
  keywords: "keywords",
  latitude: "latitude_deg",
  local_code: "local_code",
  longitude: "longitude_deg",
  municipality: "municipality",
  name: "name",
  scheduled_service: "scheduled_service",
  type: "type",
  wikipedia_link: "wikipedia_link"
}

Expected result:

iex(1)> Airports.all() |> List.first()
%Airports.Airport{
  continent: "NA",
  elevation_ft: "11",
  gps_code: "00A",
  home_link: "",
  iata_code: "",
  ident: "00A",
  iso_country: "US",
  iso_region: "US-PA",
  keywords: "",
  latitude: "40.07080078125",
  local_code: "00A",
  longitude: "-74.93360137939453",
  municipality: "Bensalem",
  name: "Total Rf Heliport",
  scheduled_service: "no",
  type: "heliport",
  wikipedia_link: ""
}

@sjoulbak
Copy link
Member

Closed by #22

@sjoulbak sjoulbak closed this Jul 19, 2024
sjoulbak pushed a commit that referenced this pull request Jul 23, 2024
…checkout-3

Bump actions/checkout from 2 to 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants