Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue #313

Closed
hamid-eis opened this issue Oct 24, 2022 · 6 comments
Closed

Dependency issue #313

hamid-eis opened this issue Oct 24, 2022 · 6 comments
Labels

Comments

@hamid-eis
Copy link

I'm submitting a...


[ ] Regression 
[*] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When installing I get this error


npm ERR! Found: @nestjs/[email protected]
npm ERR! node_modules/@nestjs/common
npm ERR!   @nestjs/common@"^9.1.4" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @nestjs/common@"^8.0.0" from @nestjs/[email protected]
npm ERR! node_modules/@nestjs/azure-storage
npm ERR!   @nestjs/azure-storage@"^3.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Expected behavior

It should install without any error. I think a pull request is already created to update this package's dependencies to nestjs latest version.

Environment


Nest version: 9.0.0

 
For Tooling issues:
- Node version: 16.18.0  
- Platform: Windows 

@CryptoIO
Copy link

Same issue for this

@sampaiorafael
Copy link

Same here. Any way to bypass or solve this without break everything?

@hamid-eis
Copy link
Author

I used the --force flag to install dependencies. That resolved it for me.

@manekinekko
Copy link
Collaborator

Is this related to #329 cc @NikolaPeevski ?

@NikolaPeevski
Copy link
Contributor

@manekinekko @kamilmysliwiec Not exactly, #329 is about making the package build, not to make it compatible with the latest nest versions (10 and 11), more specifically
https://github.com/nestjs/azure-storage/blob/master/package.json#L20 these 3.
I'll open a ticket in a bit and put another pull request in a few hours. Tested locally the migration to nest peer 10 and 11 and there doesn't appear to be neither build time breaking changes nor run time (validated by the test cases)

@manekinekko
Copy link
Collaborator

Thank you for taking the time to explore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants