-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(azure-storage-service): fix test #148
tests(azure-storage-service): fix test #148
Conversation
to be evaluated :-) |
Thank you for this contribution 👍 |
@Tony133 Could you provide more feedback about the reason for this change? |
Hi @manekinekko, I made this change because I had made another pull this #144 gave this error in tests:
which has nothing to do with what I had done, so I tried to see if I could solve it. The solution at the moment looks like this I hope it will go well. |
Oh! I see what was the error. It seems that the error message of the exception that is thrown when a file is from:
To:
I've sent you few changes to make before merging the PR. |
Co-authored-by: Wassim Chegham <[email protected]>
Any chance this can get merged so that the build can be fixed please 🙏 ? I'm keen to make use of the feature added with #65 but the build has been broken since it was merged in last year :( |
Co-authored-by: Wassim Chegham <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This PR, fix test error "should fail upload when File is null"