feat(azure-storage): added the ability to access the underlying BlobServiceClient #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 21, 2022 20:36
This commit mainly add the ablity to get the BlobServiceClient from the AzureStorageService, to avoid duplicate configuration Servel other tasks where required: (updating @azure/storage, adding new (function) tests (using azurite) to test the client
The dependencies and vurnabilities therein really need to be resolved sometime. (master wont install)
Outternet
changed the title
Outternet
changed the title
Outternet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mainly add the ablity to get the BlobServiceClient from the AzureStorageService, to avoid duplicate configuration
Servel other tasks where required: Updating depedencies, add emulator based testing, add serviceUrlProvider.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It is currently not possible to re-download or otherwise manipulate a file after upload reusing the config defined in the AzureStorageModule.
blob.storage.core.windows.net.What is the new behavior?
npm run functiontestserviceUrlProvider: () => "my new url"service.getContainerClient().<do something>Does this PR introduce a breaking change?
Other information
Although no breaking changes have been made in this PR, some questionable decisions have been made in the past (in the current version). This is especially true of the
UploadedFileMetadatathat currently provides options that are not being used during upload. (Unless I'm missing something).The problem in #142 is much deeper and requires more work than expected and possibly breaking changes. That PR still has some interesting helpers/ideas that could be added, but are beyond the scope of this PR.
The dependencies are broken, old and vulnerable. I didn't want to make any (breaking) changes to this PR, so I left it primarily as is.