fix inherited constructor params types

[dominikjasek]

PR Checklist

• fixes How about changing the constructor parameter type of PassportStrategy like this? #1072
• motivation, why this is needed: https://tsplay.dev/mb3o9W

PR Type

What kind of change does this PR introduce?

• type safety improvement

What is the current behavior?

• missing type safety

What is the new behavior?

• stronger type safety

Does this PR introduce a breaking change?

• Yes

It requires developer to really implement validate method as mentioned here. previously, you could pass it to super() by providing verify argument.

That means, previously, this was valid code:

@Injectable()
export class EcmsApiKeyStrategy extends PassportStrategy(HeaderAPIKeyStrategy, "api-key") {
    constructor() {
        super(
            { header: 'Authorization', prefix: 'Api-Key ' },
            true,
            (apikey: string, done: (...args: unknown[]) => void) => {
                return done(null, apikey === "some-random-token");
            },
        );
    }
}

but after this PR, I have to write:

@Injectable()
export class EcmsApiKeyStrategy extends PassportStrategy(HeaderAPIKeyStrategy, "api-key") {
    constructor() {
        super(
            { header: 'Authorization', prefix: 'Api-Key ' },
            true,
        );
    }

  validate(request: Request, payload: any) => {
      // here I will implement the logic
  }
}

[przemyslawwalczak]

that would be awesome! 🙏 cc @kamilmysliwiec

[kamilmysliwiec]

Great PR! Since it introduces a minor breaking change, we'll have to wait to merge it until the next major release.