feat(@nestjs/passport): segregate authenticate opts from module opts #1610
+140
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #947
AuthGuard
's constructor receives, by injection, theAuthModuleOptions
object, that's responsible to configure the module of this library;AuthGuard.getAuthenticateOptions
returns an object that matches the interfaceIAuthModuleOptions
;AuthGuard.canActivate
obtain the options fromgetAuthenticateOptions
and merges it with the injected options of theAuthGuard
instance;AuthGuard.canActivate
pass the merged options topassport.authenticate
.What is the new behavior?
AuthGuard
's constructor receives, by injection, theAuthModuleOptions
object, that's responsible to configure the module of this library withinauthenticateOptions
property to generate the options parameter to callpassport.authenticate
function.AuthGuard.getAuthenticateOptions
returns an object that matches thepassport.AuthenticateOptions
interface;AuthGuard.canActivate
obtain the options fromgetAuthenticateOptions
and merges it with theauthenticateOptions
from the injected options of theAuthGuard
instance;AuthGuard.canActivate
pass the merged options topassport.authenticate
.Does this PR introduce a breaking change?
If the user defines some authenticate option when registering the authentication module by the module options, it must be defined inside
authenticateOptions
property.Other information
No more information.