Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple import/export route maps #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

support multiple import/export route maps #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
160fe69
support multiple import/export route maps + ran precommit + manually …
abbasaysha Feb 3, 2025
f0b718b
updated description
abbasaysha Feb 3, 2025
1f7ab5a
updated description - ran pre-commit, failed first time but passed se…
abbasaysha Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions modules/terraform-aci-l3out/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,9 @@ module "aci_l3out" {
| <a name="input_default_route_leak_policy_context_scope"></a> [default\_route\_leak\_policy\_context\_scope](#input\_default\_route\_leak\_policy\_context\_scope) | Default route leak policy context scope. | `bool` | `true` | no |
| <a name="input_default_route_leak_policy_outside_scope"></a> [default\_route\_leak\_policy\_outside\_scope](#input\_default\_route\_leak\_policy\_outside\_scope) | Default route leak policy outside scope. | `bool` | `true` | no |
| <a name="input_redistribution_route_maps"></a> [redistribution\_route\_maps](#input\_redistribution\_route\_maps) | List of redistribution route maps. Choices `source`: `direct`, `attached-host`, `static`. Default value `source`: `static`. | <pre>list(object({<br> source = optional(string, "static")<br> route_map = string<br> }))</pre> | `[]` | no |
| <a name="input_import_route_map_name"></a> [import\_route\_map\_name](#input\_import\_route\_map\_name) | Import Route Map Name. Default value: `default-import` | `string` | `"default-import"` | no |
| <a name="input_import_route_map_description"></a> [import\_route\_map\_description](#input\_import\_route\_map\_description) | Import route map description. | `string` | `""` | no |
| <a name="input_import_route_map_type"></a> [import\_route\_map\_type](#input\_import\_route\_map\_type) | Import route map type. Choices: `combinable`, `global`. | `string` | `"combinable"` | no |
| <a name="input_import_route_map_names"></a> [import\_route\_map\_names](#input\_import\_route\_map\_names) | List of Import Route Map names. | <pre>list(object({<br> name = string<br> description = optional(string, "")<br> type = string<br> }))</pre> | `[]` | no |
| <a name="input_import_route_map_contexts"></a> [import\_route\_map\_contexts](#input\_import\_route\_map\_contexts) | List of import route map contexts. Choices `action`: `permit`, `deny`. Default value `action`: `permit`. Allowed values `order`: 0-9. Default value `order`: 0. | <pre>list(object({<br> name = string<br> description = optional(string, "")<br> action = optional(string, "permit")<br> order = optional(number, 0)<br> set_rule = optional(string)<br> match_rules = optional(list(string), [])<br> }))</pre> | `[]` | no |
| <a name="input_export_route_map_name"></a> [export\_route\_map\_name](#input\_export\_route\_map\_name) | Export Route Map Name. Default value: `default-export` | `string` | `"default-export"` | no |
| <a name="input_export_route_map_description"></a> [export\_route\_map\_description](#input\_export\_route\_map\_description) | Import route map description. | `string` | `""` | no |
| <a name="input_export_route_map_type"></a> [export\_route\_map\_type](#input\_export\_route\_map\_type) | Import route map type. Choices: `combinable`, `global`. | `string` | `"combinable"` | no |
| <a name="input_export_route_map_names"></a> [export\_route\_map\_names](#input\_export\_route\_map\_names) | List of Export Route Map names. | <pre>list(object({<br> name = string<br> description = optional(string, "")<br> type = string<br> }))</pre> | `[]` | no |
| <a name="input_export_route_map_contexts"></a> [export\_route\_map\_contexts](#input\_export\_route\_map\_contexts) | List of export route map contexts. Choices `action`: `permit`, `deny`. Default value `action`: `permit`. Allowed values `order`: 0-9. Default value `order`: 0. | <pre>list(object({<br> name = string<br> description = optional(string, "")<br> action = optional(string, "permit")<br> order = optional(number, 0)<br> set_rule = optional(string)<br> match_rules = optional(list(string), [])<br> }))</pre> | `[]` | no |
| <a name="input_multipod"></a> [multipod](#input\_multipod) | Multipod L3out flag. | `bool` | `true` | no |
| <a name="input_sr_mpls"></a> [sr\_mpls](#input\_sr\_mpls) | SR MPLS L3out flag. | `bool` | `false` | no |
Expand Down
32 changes: 15 additions & 17 deletions modules/terraform-aci-l3out/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,6 @@ resource "aci_rest_managed" "l3extRsEctx" {
}
}

resource "aci_rest_managed" "rtctrlProfile_import" {
count = length(var.import_route_map_contexts) > 0 ? 1 : 0
dn = "${aci_rest_managed.l3extOut.dn}/prof-${var.import_route_map_name}"
class_name = "rtctrlProfile"
content = {
name = var.import_route_map_name
descr = var.import_route_map_description
type = var.import_route_map_type
}
}

resource "aci_rest_managed" "rtctrlCtxP_import" {
for_each = { for context in var.import_route_map_contexts : context.name => context }
dn = "${aci_rest_managed.rtctrlProfile_import[0].dn}/ctx-${each.value.name}"
Expand Down Expand Up @@ -131,16 +120,25 @@ resource "aci_rest_managed" "rtctrlRsCtxPToSubjP_import" {
}

resource "aci_rest_managed" "rtctrlProfile_export" {
count = length(var.export_route_map_contexts) > 0 ? 1 : 0
dn = "${aci_rest_managed.l3extOut.dn}/prof-${var.export_route_map_name}"
for_each = { for export_route_map_name in var.export_route_map_names : export_route_map_name.name => export_route_map_name }
dn = "${aci_rest_managed.l3extOut.dn}/prof-${each.value.name}"
class_name = "rtctrlProfile"
content = {
name = var.export_route_map_name
descr = var.export_route_map_description
type = var.export_route_map_type
name = each.value.name
descr = each.value.description
type = each.value.type
}
}
resource "aci_rest_managed" "rtctrlProfile_import" {
for_each = { for import_route_map_name in var.import_route_map_names : import_route_map_name.name => import_route_map_name }
dn = "${aci_rest_managed.l3extOut.dn}/prof-${each.value.name}"
class_name = "rtctrlProfile"
content = {
name = each.value.name
descr = each.value.description
type = each.value.type
}
}

resource "aci_rest_managed" "rtctrlCtxP_export" {
for_each = { for context in var.export_route_map_contexts : context.name => context }
dn = "${aci_rest_managed.rtctrlProfile_export[0].dn}/ctx-${each.value.name}"
Expand Down
88 changes: 39 additions & 49 deletions modules/terraform-aci-l3out/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,37 +271,33 @@ variable "redistribution_route_maps" {
}
}

variable "import_route_map_name" {
description = "Import Route Map Name. Default value: `default-import`"
type = string
default = "default-import"

variable "import_route_map_names" {
description = "List of Import Route Map names."
type = list(object({
name = string
description = optional(string, "")
type = string
}))
default = []
validation {
condition = can(regex("^[a-zA-Z0-9_.:-]{0,64}$", var.import_route_map_name))
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
condition = alltrue([
for c in var.import_route_map_names : can(regex("^[a-zA-Z0-9_.:-]{0,64}$", c.name))
])
error_message = "`name`: Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
}
}

variable "import_route_map_description" {
description = "Import route map description."
type = string
default = ""

validation {
condition = can(regex("^[a-zA-Z0-9\\\\!#$%()*,-./:;@ _{|}~?&+]{0,128}$", var.import_route_map_description))
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `\\`, `!`, `#`, `$`, `%`, `(`, `)`, `*`, `,`, `-`, `.`, `/`, `:`, `;`, `@`, ` `, `_`, `{`, `|`, }`, `~`, `?`, `&`, `+`. Maximum characters: 128."
condition = alltrue([
for c in var.import_route_map_names : c.description == null || try(can(regex("^[a-zA-Z0-9\\\\!#$%()*,-./:;@ _{|}~?&+]{0,128}$", c.description)), false)
])
error_message = "`name`: Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `\\`, `!`, `#`, `$`, `%`, `(`, `)`, `*`, `,`, `-`, `.`, `/`, `:`, `;`, `@`, ` `, `_`, `{`, `|`, }`, `~`, `?`, `&`, `+`. Maximum characters: 128."
}
}

variable "import_route_map_type" {
description = "Import route map type. Choices: `combinable`, `global`."
type = string
default = "combinable"

validation {
condition = contains(["combinable", "global"], var.import_route_map_type)
condition = alltrue([
for c in var.import_route_map_names : c.type == null || contains(["combinable", "global"], c.type)
])
error_message = "Allowed values are `combinable` or `global`."
}

}

variable "import_route_map_contexts" {
Expand Down Expand Up @@ -361,39 +357,33 @@ variable "import_route_map_contexts" {
}
}

variable "export_route_map_name" {
description = "Export Route Map Name. Default value: `default-export`"
type = string
default = "default-export"

variable "export_route_map_names" {
description = "List of Export Route Map names."
type = list(object({
name = string
description = optional(string, "")
type = string
}))
default = []
validation {
condition = can(regex("^[a-zA-Z0-9_.:-]{0,64}$", var.export_route_map_name))
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
condition = alltrue([
for c in var.export_route_map_names : can(regex("^[a-zA-Z0-9_.:-]{0,64}$", c.name))
])
error_message = "`name`: Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
}
}

variable "export_route_map_description" {
description = "Import route map description."
type = string
default = ""

validation {
condition = can(regex("^[a-zA-Z0-9\\\\!#$%()*,-./:;@ _{|}~?&+]{0,128}$", var.export_route_map_description))
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `\\`, `!`, `#`, `$`, `%`, `(`, `)`, `*`, `,`, `-`, `.`, `/`, `:`, `;`, `@`, ` `, `_`, `{`, `|`, }`, `~`, `?`, `&`, `+`. Maximum characters: 128."
condition = alltrue([
for c in var.export_route_map_names : c.description == null || try(can(regex("^[a-zA-Z0-9\\\\!#$%()*,-./:;@ _{|}~?&+]{0,128}$", c.description)), false)
])
error_message = "`name`: Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `\\`, `!`, `#`, `$`, `%`, `(`, `)`, `*`, `,`, `-`, `.`, `/`, `:`, `;`, `@`, ` `, `_`, `{`, `|`, }`, `~`, `?`, `&`, `+`. Maximum characters: 128."
}
}

variable "export_route_map_type" {
description = "Import route map type. Choices: `combinable`, `global`."
type = string
default = "combinable"

validation {
condition = contains(["combinable", "global"], var.export_route_map_type)
condition = alltrue([
for c in var.export_route_map_names : c.type == null || contains(["combinable", "global"], c.type)
])
error_message = "Allowed values are `combinable` or `global`."
}
}

variable "export_route_map_contexts" {
description = "List of export route map contexts. Choices `action`: `permit`, `deny`. Default value `action`: `permit`. Allowed values `order`: 0-9. Default value `order`: 0."
type = list(object({
Expand Down
Loading