Implemented csv2yaml convertor #103

moskvin · 2018-02-27T11:54:19Z

Added

csv2yaml convertor

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/version.rb

@@ -1,3 +1,3 @@
 module Babelish
-  VERSION = "0.5.3"
+  VERSION = "0.6.0"


Freeze mutable objects assigned to constants.

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/csv2yaml.rb

+    end
+  end
+end
+


1 trailing blank lines detected.

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/csv2yaml.rb

+      end
+      indent = '  '
+      entry += comment.to_s.empty? ? "" : "#{indent}# #{comment}\n"
+      entry += "#{indent}#{row_key}: \"#{row_value}\"\n"


Useless assignment to variable - entry. Use + instead of +=.

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/csv2yaml.rb

+        entry += "#{@language.code}:\n"
+        @is_first_row = false
+      end
+      indent = '  '


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

not agree with the bot

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/csv2yaml.rb

+      return filepath ? [filepath] : []
+    end
+
+    def get_row_format(row_key, row_value, comment = nil, indentation = 0)


Unused method argument - indentation. If it's necessary, use _ or _indentation as an argument name to indicate that it won't be used.

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/csv2yaml.rb

+      filename = @output_basename || language.code
+      filepath = Pathname.new("#{@output_dir}/#{filename}.#{extension}")
+      @language = language
+      return filepath ? [filepath] : []


Redundant return detected.

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/csv2yaml.rb

+    end
+
+    def language_filepaths(language)
+      require 'pathname'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

not agree with the bot

houndci-bot · 2018-02-27T11:54:30Z

lib/babelish/csv2yaml.rb

@@ -0,0 +1,34 @@
+module Babelish


Missing magic comment # frozen_string_literal: true.

rubocop | grep frozen_string_literal does not have it.

netbe · 2018-02-27T19:10:49Z

@moskvin thanks for the contribution,

Please add some unit tests and have you look at the @houndci-bot comments.

Also did you look athttps://github.com/netbe/Babelish/tree/feature/yaml?
Also would be cool to have yaml2csv?

…2yaml.rb`

houndci-bot · 2018-03-24T04:49:47Z

lib/babelish/csv2yaml.rb

+    end
+
+    def extension
+      'yaml'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

I will not fix it!

houndci-bot · 2018-03-24T04:49:47Z

lib/babelish/csv2yaml.rb

+    end
+
+    def get_row_format(row_key, row_value, comment = nil, _indentation = 0)
+      entry = ''


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

I will not fix it!

moskvin · 2018-03-24T04:53:34Z

Also did you look athttps://github.com/netbe/Babelish/tree/feature/yaml?

no, I was surprised :)

moskvin · 2018-03-24T04:54:58Z

Also would be cool to have yaml2csv?

not required right now for me, but I think we should add it

moskvin · 2018-03-24T04:56:01Z

@netbe If you want to achieve clean code for the project I suggest use rubocop

houndci-bot · 2018-03-26T10:05:40Z

lib/babelish/csv2yaml.rb

+    end
+
+    def extension
+      'yaml'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-26T10:05:40Z

lib/babelish/csv2yaml.rb

+        @is_first_row = false
+      end
+      entry << "#{indent*2}# #{comment}\n" unless comment.to_s.empty?
+      entry << "#{indent*2}#{row_key}: \"#{row_value}\"\n"


Surrounding space missing for operator *.

houndci-bot · 2018-03-26T10:05:40Z

lib/babelish/csv2yaml.rb

+        entry << "#{indent}#{filename}:\n"
+        @is_first_row = false
+      end
+      entry << "#{indent*2}# #{comment}\n" unless comment.to_s.empty?


Surrounding space missing for operator *.

houndci-bot · 2018-03-26T10:05:40Z

lib/babelish/csv2yaml.rb

+
+    def get_row_format(row_key, row_value, comment = nil, _indentation = 0)
+      entry = ''
+      indent = '  '


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-26T10:05:41Z

lib/babelish/csv2yaml.rb

+    def language_filepaths(language)
+      require 'pathname'
+      filename = @output_basename || language.code
+      filepath = Pathname.new("#{@output_dir}/#{filename}.#{language.code}.#{extension}")


Line is too long. [89/80]

houndci-bot · 2018-03-26T10:21:28Z

lib/babelish/csv2yaml.rb

+    def extension
+      'yaml'
+    end
+


Extra empty line detected at class body end.

houndci-bot · 2018-03-26T10:21:28Z

lib/babelish/csv2yaml.rb

+    end
+
+    def extension
+      'yaml'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-26T10:21:28Z

lib/babelish/csv2yaml.rb

+        @is_first_row = false
+      end
+      entry << "#{indent*@deep}# #{comment}\n" unless comment.to_s.empty?
+      entry << "#{indent*@deep}#{row_key}: \"#{row_value}\"\n"


Surrounding space missing for operator *.

houndci-bot · 2018-03-26T10:21:28Z

lib/babelish/csv2yaml.rb

+        end
+        @is_first_row = false
+      end
+      entry << "#{indent*@deep}# #{comment}\n" unless comment.to_s.empty?


Surrounding space missing for operator *.

houndci-bot · 2018-03-26T10:21:28Z

lib/babelish/csv2yaml.rb

+
+    def get_row_format(row_key, row_value, comment = nil, indentation = 0)
+      entry = ''
+      indent = '  '


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-26T10:21:29Z

lib/babelish/csv2yaml.rb

+    end
+
+    def get_row_format(row_key, row_value, comment = nil, indentation = 0)
+      entry = ''


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-26T10:21:29Z

lib/babelish/csv2yaml.rb

+      filepath ? [filepath] : []
+    end
+
+    def get_row_format(row_key, row_value, comment = nil, indentation = 0)


Unused method argument - indentation. If it's necessary, use _ or _indentation as an argument name to indicate that it won't be used.

houndci-bot · 2018-03-26T10:21:29Z

lib/babelish/csv2yaml.rb

+    end
+
+    def language_filepaths(language)
+      require 'pathname'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-27T10:02:26Z

lib/babelish/csv2strings.rb

+
+    def to_camel_case underscope_text
+      enumerator = underscope_text.split('_').each_with_index
+      enumerator.map{|word, index| index == 0 ? word : word.capitalize}.join


Space missing to the left of {.
Space between { and | missing.
Use index.zero? instead of index == 0.
Space missing inside }.

houndci-bot · 2018-03-27T10:02:26Z

lib/babelish/csv2strings.rb

@@ -27,5 +27,10 @@ def extension
    def output_basename
      @output_basename || 'Localizable'
    end
+
+    def to_camel_case underscope_text
+      enumerator = underscope_text.split('_').each_with_index


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-03-27T10:02:26Z

lib/babelish/csv2strings.rb

@@ -27,5 +27,10 @@ def extension
    def output_basename
      @output_basename || 'Localizable'
    end
+
+    def to_camel_case underscope_text


Use def with parentheses when there are parameters.

houndci-bot · 2018-03-27T10:02:26Z

lib/babelish/csv2strings.rb

@@ -17,7 +17,7 @@ def language_filepaths(language)

    def get_row_format(row_key, row_value, comment = nil, indentation = 0)
      entry = comment.to_s.empty? ? "" : "\n/* #{comment} */\n" 
-      entry + "\"#{row_key}\"" + " " * indentation + " = \"#{row_value}\";\n"
+      entry + "\"#{to_camel_case(row_key)}\"" + " " * indentation + " = \"#{row_value}\";\n"


Line is too long. [92/80]

houndci-bot · 2018-04-01T04:21:46Z

lib/babelish/csv2strings.rb

+    end
+
+    def filename_to_camel_case underscope_text
+      underscope_text.split('_').map{|word| word.capitalize}.join


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Space missing to the left of {.
Space between { and | missing.
Pass &:capitalize as an argument to map instead of a block.
Space missing inside }.

houndci-bot · 2018-04-01T04:21:46Z

lib/babelish/csv2strings.rb

+      enumerator.map{|word, index| index == 0 ? word : word.capitalize}.join
+    end
+
+    def filename_to_camel_case underscope_text


Use def with parentheses when there are parameters.

houndci-bot · 2018-04-01T04:21:46Z

lib/babelish/csv2strings.rb

+
+    def row_to_camel_case underscope_text
+      enumerator = underscope_text.split('_').each_with_index
+      enumerator.map{|word, index| index == 0 ? word : word.capitalize}.join


Space missing to the left of {.
Space between { and | missing.
Use index.zero? instead of index == 0.
Space missing inside }.

houndci-bot · 2018-04-01T04:21:46Z

lib/babelish/csv2strings.rb

@@ -27,5 +28,14 @@ def extension
    def output_basename
      @output_basename || 'Localizable'
    end
+
+    def row_to_camel_case underscope_text
+      enumerator = underscope_text.split('_').each_with_index


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-01T04:21:46Z

lib/babelish/csv2strings.rb

@@ -27,5 +28,14 @@ def extension
    def output_basename
      @output_basename || 'Localizable'
    end
+
+    def row_to_camel_case underscope_text


Use def with parentheses when there are parameters.

houndci-bot · 2018-04-01T04:21:46Z

lib/babelish/csv2strings.rb

        end
      end
      filepaths
    end

    def get_row_format(row_key, row_value, comment = nil, indentation = 0)
      entry = comment.to_s.empty? ? "" : "\n/* #{comment} */\n" 
-      entry + "\"#{row_key}\"" + " " * indentation + " = \"#{row_value}\";\n"
+      entry + "\"#{row_to_camel_case(row_key)}\"" + " " * indentation + " = \"#{row_value}\";\n"


Line is too long. [96/80]

…mel case [csv2strings] Added convertor for filename from underscore case to camel case

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/FileName has the wrong namespace - should be Naming

.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot · 2018-04-06T05:22:46Z

lib/babelish/version.rb

@@ -1,3 +1,3 @@
 module Babelish
-  VERSION = "0.5.4"
+  VERSION = '0.6.0'.freeze


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-06T05:22:46Z

lib/babelish/csv2yaml.rb

+    end
+
+    def extension
+      'yaml'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-06T05:22:46Z

lib/babelish/csv2yaml.rb

+
+    def get_row_format(row_key, row_value, comment = nil, _indentation = 0)
+      entry = ''
+      indent = '  '


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-06T05:22:47Z

lib/babelish/csv2yaml.rb

+    end
+
+    def get_row_format(row_key, row_value, comment = nil, _indentation = 0)
+      entry = ''


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-06T05:22:47Z

lib/babelish/csv2yaml.rb

+    end
+
+    def language_filepaths(language)
+      require 'pathname'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-06T05:22:47Z

lib/babelish/csv2strings.rb

+
+    def row_to_camel_case(underscope_text)
+      enumerator = underscope_text.split('_').each_with_index
+      enumerator.map{|word, index| index == 0 ? word : word.capitalize}.join


Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Style/NumericPredicate: Use index.zero? instead of index == 0.
Layout/SpaceInsideBlockBraces: Space missing inside }.

houndci-bot · 2018-04-06T05:22:47Z

lib/babelish/csv2strings.rb

    def extension
      "strings"
    end

    def output_basename
      @output_basename || 'Localizable'
    end
+
+    def row_to_camel_case(underscope_text)
+      enumerator = underscope_text.split('_').each_with_index


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-06T05:22:47Z

lib/babelish/csv2strings.rb

      else
        language.regions.each do |region|
-          filepaths << Pathname.new(@output_dir) + "#{language.code}-#{region}.lproj/#{output_basename}.#{extension}"
+          filepaths << Pathname.new(@output_dir) + "#{language.code}-#{region}.lproj/#{basename}.#{extension}"


Metrics/LineLength: Line is too long. [110/80]

houndci-bot · 2018-04-06T05:22:47Z

lib/babelish/csv2strings.rb

      if language.regions.empty?
-        filepaths << Pathname.new(@output_dir) + "#{language.code}.lproj/#{output_basename}.#{extension}"
+        filepaths << Pathname.new(@output_dir) + "#{language.code}.lproj/#{basename}.#{extension}"


Metrics/LineLength: Line is too long. [98/80]

houndci-bot · 2018-04-06T05:22:47Z

lib/babelish/csv2base.rb

-          output += get_row_format(key, value, comment, indentation - key.length)
+          key_out = key_to_output(key)
+          value_out = value_to_output(value)
+          output += get_row_format(key_out, value_out, comment, indentation - key_out.length)


Metrics/LineLength: Line is too long. [93/80]

houndci-bot · 2018-04-11T11:28:41Z

lib/babelish/csv2json.rb

@@ -5,7 +5,7 @@ class CSV2JSON < Csv2Base
    def language_filepaths(language)
      require 'pathname'
      filename = @output_basename || language.code
-      filepath = Pathname.new("#{@output_dir}#{filename}.#{extension}")
+      filepath = Pathname.new("#{@output_dir}/#{filename}.#{language.code}.#{extension}")


Metrics/LineLength: Line is too long. [89/80]

[gems] updated gems

houndci-bot · 2021-08-20T08:04:21Z

Gemfile


 # Specify your gem's dependencies in teachmehowtomakearubygem.gemspec
 gemspec

 group :test do
-  gem 'coveralls', :require => false, :platforms => [:ruby_19, :ruby_20]
+  gem 'coveralls', require: false, platforms: %i[ruby_19 ruby_20]
+  gem 'rubocop'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2021-08-20T08:04:21Z

Gemfile


 # Specify your gem's dependencies in teachmehowtomakearubygem.gemspec
 gemspec

 group :test do
-  gem 'coveralls', :require => false, :platforms => [:ruby_19, :ruby_20]
+  gem 'coveralls', require: false, platforms: %i[ruby_19 ruby_20]


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2021-08-20T08:04:22Z

Gemfile

@@ -1,8 +1,9 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2021-08-20T08:04:22Z

Rakefile

 require 'rake/testtask'
 require 'yard'

 Rake::TestTask.new do |t|
-  t.libs << "test"
+  t.libs << 'test'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2021-08-20T08:04:22Z

Rakefile

@@ -1,9 +1,9 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot reviewed Feb 27, 2018

View reviewed changes

Nikolay Moskvin added 2 commits March 24, 2018 11:24

Implemented csv2yaml convertor

3e17922

Fixed comments from houndci-bot. Checked by `rubocop lib/babelish/csv…

c459f2c

…2yaml.rb`

moskvin force-pushed the master branch from 6b716d7 to c459f2c Compare March 24, 2018 04:49

houndci-bot reviewed Mar 24, 2018

View reviewed changes

houndci-bot reviewed Mar 26, 2018

View reviewed changes

Nikolay Moskvin added 2 commits March 26, 2018 17:20

[csv2yaml] Added prefix and changed filename for yaml files

f17032f

[csv2android] Added prefix for android files

c36acd0

moskvin force-pushed the master branch from 5f469ad to c36acd0 Compare March 26, 2018 10:21

houndci-bot reviewed Mar 26, 2018

View reviewed changes

houndci-bot reviewed Mar 27, 2018

View reviewed changes

houndci-bot reviewed Apr 1, 2018

View reviewed changes

[csv2strings] Added convertor for all keys from underscore case to ca…

8828bea

…mel case [csv2strings] Added convertor for filename from underscore case to camel case

moskvin force-pushed the master branch from 0d851ce to 8828bea Compare April 1, 2018 09:23

houndci-bot reviewed Apr 1, 2018

View reviewed changes

Nikolay Moskvin added 2 commits April 6, 2018 12:10

[csv2strings] Added convert from %s to %@

7690d9a

Added rubocop

1f5baa5

houndci-bot reviewed Apr 6, 2018

View reviewed changes

Nikolay Moskvin added 2 commits April 7, 2018 14:12

[csv2yaml] Changed extension name to yml

1332d23

[csv2json] Added language code to name of file

fc75148

houndci-bot reviewed Apr 11, 2018

View reviewed changes

stolyarov and others added 2 commits August 20, 2021 14:26

[gems] updated gems

0f77221

Merge pull request #1 from Amphilohiy/master

8a32a15

[gems] updated gems

houndci-bot reviewed Aug 20, 2021

View reviewed changes

		@@ -1,8 +1,9 @@
		source "http://rubygems.org"
		source 'http://rubygems.org'

		@@ -1,9 +1,9 @@
		require "bundler/gem_tasks"
		require 'bundler/gem_tasks'

Implemented csv2yaml convertor #103

Are you sure you want to change the base?

Implemented csv2yaml convertor #103

Conversation

moskvin commented Feb 27, 2018

Added

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netbe commented Feb 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moskvin commented Mar 24, 2018 • edited Loading

moskvin commented Mar 24, 2018

moskvin commented Mar 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moskvin commented Mar 24, 2018 •

edited

Loading