Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow object types for ingress paths #398

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: allow object types for ingress paths #398

merged 2 commits into from
Oct 28, 2024

Conversation

jon4hz
Copy link
Contributor

@jon4hz jon4hz commented Oct 28, 2024

Hi,

Your helm chart theoretically accepts object types for ingress paths, however the json schema currently only allows strings.

This PR changes the schema so both string and object types are allowed.

LeoColomb
LeoColomb approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM 👍

@LeoColomb LeoColomb enabled auto-merge (squash) October 28, 2024 16:12
@LeoColomb LeoColomb merged commit c062d8e into netbox-community:develop Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon4hz @LeoColomb