Remove custom DNS Implementation

netboxlabs · Oct 27, 2023 · 12bad0e · 12bad0e
1 parent 167a0b1
commit 12bad0e
Show file tree

Hide file tree

Showing 28 changed files with 137 additions and 3,115 deletions.
diff --git a/libs/CMakeLists.txt b/libs/CMakeLists.txt
@@ -2,6 +2,5 @@ message(STATUS "Custom Libraries")
 
 add_subdirectory(visor_test)
 add_subdirectory(visor_transaction)
-add_subdirectory(visor_tcp)
 add_subdirectory(visor_dns)
 add_subdirectory(visor_utils)
diff --git a/libs/visor_dns/CMakeLists.txt b/libs/visor_dns/CMakeLists.txt
@@ -2,9 +2,6 @@ message(STATUS "Visor Lib DNS Helper")
 
 add_library(VisorLibDns
         dns.cpp
-        DnsLayer.cpp
-        DnsResource.cpp
-        DnsResourceData.cpp
         )
 add_library(Visor::Lib::Dns ALIAS VisorLibDns)
 
@@ -15,7 +12,6 @@ target_include_directories(VisorLibDns
 
 target_link_libraries(VisorLibDns
         PUBLIC
-        Visor::Lib::Tcp
         ${CONAN_LIBS_PCAPPLUSPLUS}
         ${CONAN_LIBS_PTHREADS4W}
         ${CONAN_LIBS_LIBPCAP}

diff --git a/libs/visor_dns/DnsAdditionalRecord.h b/libs/visor_dns/DnsAdditionalRecord.h
@@ -9,8 +9,7 @@
 #else
 #include <arpa/inet.h>
 #endif
-#include "DnsResource.h"
-#include "EndianPortable.h"
+#include <DnsResource.h>
 #include <algorithm>
 #include <array>
 
@@ -46,10 +45,10 @@ struct DnsAdditionalEcs {
     std::string client_subnet;
 };
 
-static std::unique_ptr<DnsAdditionalEcs> parse_additional_records_ecs(DnsResource *additional)
+static std::unique_ptr<DnsAdditionalEcs> parse_additional_records_ecs(pcpp::DnsResource *additional)
 {
 
-    if (!additional || additional->getDnsType() != DnsType::DNS_TYPE_OPT || additional->getDataLength() == 0) {
+    if (!additional || additional->getDnsType() != pcpp::DnsType::DNS_TYPE_OPT || additional->getDataLength() == 0) {
         return nullptr;
     }