Skip to content

Commit

Permalink
chore: GHA cross build upload artifacts fix (#745)
Browse files Browse the repository at this point in the history
* chore: GHA cross build upload artifacts fix

* update libasan version
  • Loading branch information
leoparente authored Jan 21, 2025
1 parent 85284ea commit 3e4ebd5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_cross.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,14 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: pktvisord-linux-${{matrix.arch}}-static
path: build/bin/pktvisord
path: ${{github.workspace}}/src/build/bin/pktvisord
retention-days: 7

- name: Upload pktvisor-reader
uses: actions/upload-artifact@v4
with:
name: pktvisor-reader-linux-${{matrix.arch}}-static
path: build/bin/pktvisor-reader
path: ${{github.workspace}}/src/build/bin/pktvisor-reader
retention-days: 7

pkvisor-cli:
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM ubuntu:noble AS cppbuild

ENV BUILD_DEPS "g++ cmake make automake autoconf git pkgconf jq python3 python3-pip python3-setuptools ca-certificates"
ENV BUILD_DEPS "g++ cmake make automake autoconf git pkgconf jq python3 libasan8 python3-pip python3-setuptools ca-certificates"

RUN \
apt-get update && \
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.crashhandler
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM ubuntu:noble

ENV RUNTIME_DEPS "curl ca-certificates libasan6 wget gzip"
ENV RUNTIME_DEPS "curl ca-certificates libasan8 wget gzip"

Check warning on line 3 in docker/Dockerfile.crashhandler

View workflow job for this annotation

GitHub Actions / package-amd64

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 3 in docker/Dockerfile.crashhandler

View workflow job for this annotation

GitHub Actions / package-arm64

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN \
apt-get update && \
Expand Down

0 comments on commit 3e4ebd5

Please sign in to comment.