chore: fix intermittent timeouts in osx test runners #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
mrstork
commented
Jan 7, 2025
| @@ -60,12 +60,6 @@ jobs: | |||
| deno-version: 'v1.46.3' | |||
| fail-fast: false | |||
| steps: | |||
| # Increasing the maximum number of open files. See: | |||
There was a problem hiding this comment.
Unrelated, these steps don't seem to be relevant any longer
mrstork
commented
Jan 7, 2025
| @@ -4,6 +4,7 @@ import { normalize, delimiter } from 'path' | |||
| import { env } from 'process' | |||
| import { fileURLToPath } from 'url' | |||
|
|
|||
| import { default as build, startDev } from '@netlify/build' | |||
There was a problem hiding this comment.
Unrelated, hoisting the build import instead of asynchronously importing it since all fixtures use it anyhow
pieh
approved these changes
Jan 7, 2025
JakeChampion
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes FRB-1555
OSX has less memory than the other test runners and the tests seem to be crawling to a halt when running with any concurrency. This update forces the tests to be run serially (no concurrency) on osx runners, but only in GithubActions (we didn't want to affect local development)