Skip to content

Commit

Permalink
Add more filters to the audit log.
Browse files Browse the repository at this point in the history
This will allow people to filter actions and log types.

Signed-off-by: David Calavera <[email protected]>
  • Loading branch information
calavera committed Feb 13, 2018
1 parent 529ae13 commit 28c832b
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 15 deletions.
2 changes: 2 additions & 0 deletions api/audit.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import (

var filterColumnMap = map[string][]string{
"author": []string{"actor_email", "actor_name"},
"action": []string{"action"},
"type": []string{"log_type"},
}

func (a *API) adminAuditLog(w http.ResponseWriter, r *http.Request) error {
Expand Down
62 changes: 47 additions & 15 deletions api/audit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,23 +65,11 @@ func (ts *AuditTestSuite) makeSuperAdmin(email string) string {
}

func (ts *AuditTestSuite) TestAuditGet() {
// DELETE USER
u, err := models.NewUser(ts.instanceID, "[email protected]", "test", ts.Config.JWT.Aud, nil)
require.NoError(ts.T(), err, "Error making new user")
require.NoError(ts.T(), ts.API.db.Create(u), "Error creating user")

// Setup request
w := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/admin/users/%s", u.ID), nil)
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", ts.token))

ts.API.handler.ServeHTTP(w, req)
require.Equal(ts.T(), http.StatusOK, w.Code)

ts.prepareDeleteEvent()
// CHECK FOR AUDIT LOG

w = httptest.NewRecorder()
req = httptest.NewRequest(http.MethodGet, "/admin/audit", nil)
w := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, "/admin/audit", nil)
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", ts.token))

ts.API.handler.ServeHTTP(w, req)
Expand All @@ -101,3 +89,47 @@ func (ts *AuditTestSuite) TestAuditGet() {
require.Contains(ts.T(), traits, "user_email")
assert.Equal(ts.T(), "[email protected]", traits["user_email"])
}

func (ts *AuditTestSuite) TestAuditFilters() {
ts.prepareDeleteEvent()

queries := []string{
"/admin/audit?query=action:user_deleted",
"/admin/audit?query=type:team",
}

for _, q := range queries {
w := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, q, nil)
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", ts.token))

ts.API.handler.ServeHTTP(w, req)
require.Equal(ts.T(), http.StatusOK, w.Code)

logs := []models.AuditLogEntry{}
require.NoError(ts.T(), json.NewDecoder(w.Body).Decode(&logs))

require.Len(ts.T(), logs, 1)
require.Contains(ts.T(), logs[0].Payload, "actor_email")
assert.Equal(ts.T(), "[email protected]", logs[0].Payload["actor_email"])
traits, ok := logs[0].Payload["traits"].(map[string]interface{})
require.True(ts.T(), ok)
require.Contains(ts.T(), traits, "user_email")
assert.Equal(ts.T(), "[email protected]", traits["user_email"])
}
}

func (ts *AuditTestSuite) prepareDeleteEvent() {
// DELETE USER
u, err := models.NewUser(ts.instanceID, "[email protected]", "test", ts.Config.JWT.Aud, nil)
require.NoError(ts.T(), err, "Error making new user")
require.NoError(ts.T(), ts.API.db.Create(u), "Error creating user")

// Setup request
w := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodDelete, fmt.Sprintf("/admin/users/%s", u.ID), nil)
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", ts.token))

ts.API.handler.ServeHTTP(w, req)
require.Equal(ts.T(), http.StatusOK, w.Code)
}

0 comments on commit 28c832b

Please sign in to comment.