[CPLA-2135] Allow for CSP Integration to be uninstalled from team. DO NOT MERGE #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for csp-integration ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NikAiyer
changed the title
NikAiyer
changed the title
|
Currently build tokens are saved in the environment variables section and build hooks are saved in the build hooks section under Build and Deploy, which can be manually deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows removes the custom onDisable for CSP. This allows the default onDisable to run, allowing for CSP to be uninstalled from team.
This also means we don't remove existing build tokens and build hooks. We will need more investigation into how to properly dispose of those.
This is currently published as a deploy preview. https://app.netlify.com/sites/csp-integration/deploys/66fec0a4fc3c1c00084fa91d
This does not need to be merged, and deploy should be replaced when CSP v2 is fixed