Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: couble count of flow_process_nf_total #287

Closed
wants to merge 1 commit into from

Conversation

bpereto
Copy link

@bpereto bpereto commented Feb 7, 2024

I was confused about the latest total processed flow counts - if I interpreting it right, the metric of flow_process_nf_total is counted double for v9 and v10:

NetFlowStats.With(

and in the recordCommonNetFlowMetrics function:

NetFlowStats.With(

@lspgn
Copy link
Member

lspgn commented Feb 11, 2024

Good catch, it's also incremented in recordCommonNetFlowMetrics().

Thank you

@lspgn lspgn added bug Something isn't working decoders Decoding flows labels Feb 11, 2024
@lspgn
Copy link
Member

lspgn commented Mar 24, 2024

Hello,
I think I prefer removing it from recordCommonNetFlowMetrics in #302, since NetFlow v5 is also emitting the metric in the same function.
Thank you
Will close this one.

@lspgn lspgn closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working decoders Decoding flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants