Make formatter and unknown fields public in ProtoProducerMessage #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to make formatter and unknown fields map more public in
protoproducer.ProtoProducerMessage
struct.The reason is that I try to create flows enrichment in custom formatter.
My struct is:
In this scenario in method
Format(data interface{}) ([]byte, []byte, error)
I can fill additional fields without make a copy of original struct. But marshall to json needs to be done in three steps:m.ProtoProducerMessage.MarshalJSON()
to create unknownFields as fields in json and use renderers from configWith access to formatter from
ProtoProducerMessage
I could write more efficient json serializer with my fields.I also need unknown fields for two reasons:
FlowDirection == "12345" and DstAddr == IP("1.1.2.2")
).FlowDirection
is in UnknownFields, so I need to materialize them in my struct as map or fields.