Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #933 update javadoc and a test case #934

Merged
merged 1 commit into from
Jan 27, 2024
Merged

fixes #933 update javadoc and a test case #934

merged 1 commit into from
Jan 27, 2024

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Jan 26, 2024

No description provided.

@stevehu stevehu requested a review from justin-tay January 26, 2024 20:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (7f1ec11) to head (eebaeaf).
Report is 119 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #934   +/-   ##
=========================================
  Coverage     79.04%   79.04%           
  Complexity     1504     1504           
=========================================
  Files           143      143           
  Lines          4915     4915           
  Branches        932      932           
=========================================
  Hits           3885     3885           
  Misses          670      670           
  Partials        360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu
Copy link
Contributor Author

stevehu commented Jan 26, 2024

@justin-tay, One of the test cases failed on my faster desktop computer during the maven install and I am guessing it is a timing issue with other test cases. I have added ten milliseconds of sleep as a temporary solution. Do you happen to know what would cause IlegalStateException "recursive update"? If not, I think we can leave the test case as it is. Thanks a lot for the PR.

Copy link
Contributor

@justin-tay justin-tay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

I shall see if I can reproduce this later.

@stevehu stevehu merged commit b76c9f4 into master Jan 27, 2024
4 checks passed
@stevehu stevehu deleted the issue933 branch January 27, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants