init rand once #65
Merged
init rand once #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Rodionov <[email protected]>
Signed-off-by: Viktor Rodionov <[email protected]>
Hello. What do you mean? All tests are passed. Also I tested it manually. Based on that there is no regression. You want to add more scenarios? |
|
If we fixed a problem, it would be beneficial to add coverage for the issue to ensure that the developed and tested software continues to function as expected even after future changes. So, is it possible to add a test that covers the problem? |
|
This is not a functional issue. Before that everything worked correctly. It's just an improvement: initialization before was performed for each request, now - only once. From a functional point of view, nothing has changed. Because of this, the current tests cover the necessary functionality. |
denis-tingaikin
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did performance testing with fanout plugin and was found that rand.NewSource uses 4.3% of CPU
Here is a fix that moves rand initialization to weightedPolicy, so that rand is initialized only once.
Profile after the fix