Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large_community to eos bgp detail #2008

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

brandomando
Copy link
Contributor

No description provided.

@mjbear
Copy link
Contributor

mjbear commented Jan 31, 2025

@brandomando
When it comes to the failed YAML test data checks, I believe it is a result of however the test data was regenerated.

There are helper scripts that can assist with regenerating the test data.

You likely want something along the lines of:

python cli.py gen-yaml-folder -f tests/arista_eos/show_ip_bgp_detail/

Be sure to inspect the YAML files for changes.

It's possible to locally run the test cases either via Docker or local poetry environment.

Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvanderaa jvanderaa merged commit 5fd4c78 into networktocode:master Feb 4, 2025
10 checks passed
CursedEnvy pushed a commit to CursedEnvy/ntc-templates that referenced this pull request Feb 5, 2025
* add large_community to eos bgp detail

* fix yamlint errors

* Update ntc_templates/templates/arista_eos_show_ip_bgp_detail.textfsm

Co-authored-by: Michael Bear <[email protected]>

---------

Co-authored-by: Brandon Donohoe <[email protected]>
Co-authored-by: Michael Bear <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants