add arista eos show ip mroute detail template #2009
Conversation
brandomando
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
ntc_templates/templates/arista_eos_show_ip_mroute_vrf_all_detail.textfsm
Outdated
Show resolved
Hide resolved
…il.textfsm Co-authored-by: Michael Bear <[email protected]>
| ^\s{4}[RWIHZANTVF]\s- | ||
| ^(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) -> Continue.Record | ||
| ^${MULTICAST_GROUP} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ntc_templates/templates/arista_eos_show_ip_mroute_vrf_all_detail.textfsm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
If this YAML test data was regenerated with the helper scripts the keys would be in alphabetical order.
There was a problem hiding this comment.
Sorry... Friday afternoon, so I missed that one trying to get out the door ;-)
| ^\s{6}\S+ | ||
| ^\s{4}\S\s-> Continue |
There was a problem hiding this comment.
I'm going through this more closely and will provide updated regexes (most likely in a PR to your fork).
There are several regexes that are loose if it wasn't for the curly brace quantifiers.
And there's a syntax error, but that doesn't seem to cause the template to fail since it is mistaken as a pattern.
There was a problem hiding this comment.
@jmcgill298 and I used those loose regexes as an escape to the capture of the OUTGOING_INTERFACE_LIST because there was no pattern to match on in those lines to break out of that section without capturing the lines in the State summarization macros section below it. The line that matches that continue statement would be re-evaluated below. I will say, however that I put in 27 and 28 after the fact, and I did mess up the order of it there. 29 should actually be sitting above 27, directly below ^\s{6}${OUTGOING_INTERFACE_LIST}$$. I will correct that and resubmit.
There was a problem hiding this comment.
The loose ^\s{6}\S+ and changes to its whitespace were the crux of issues (that I then caused).
I've managed to remove all the curly brace quantifiers and keep the template parsing. 😅
|
@brandomando Earlier I needed to realize that loose regex in the middle was going to bite me (and cause GH Actions heartburn), apologies. |
Enhancements to Arista EOS show ip mroute
No description provided.