Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nut_usbinfo.pl: Lowercase the USB ids before inserting #2120

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

EchterAgo
Copy link
Contributor

If we don't normalize the case before inserting VID/PID/Driver into $vendor we can have duplicate entries.

@EchterAgo EchterAgo marked this pull request as ready for review October 18, 2023 16:49
@EchterAgo
Copy link
Contributor Author

Maybe this should just use lc() because C also accepts hex numbers with 0X prefix.

If we don't normalize the case before inserting VID/PID/Driver into
`$vendor` we can have duplicate entries.

Signed-off-by: Axel Gembe <[email protected]>
@EchterAgo EchterAgo force-pushed the nut_usbinfo_lowercase branch from bb121ab to 0f34b84 Compare October 18, 2023 17:19
@jimklimov jimklimov merged commit 0a7bfda into networkupstools:master Oct 18, 2023
6 checks passed
@EchterAgo EchterAgo deleted the nut_usbinfo_lowercase branch October 19, 2023 00:12
@jimklimov jimklimov added the CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) label Oct 21, 2023
@jimklimov jimklimov added this to the 2.8.1 milestone Oct 21, 2023
@jimklimov jimklimov added the USB label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) USB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants