-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/mge-hid.c, NEWS.adoc: try to recognize Eaton 9E model and info #2562
Conversation
networkupstools#1925] Also handle "unknown 2000" assuming it is a mis-read "Eaton 9E 2000(i?)" which refused to tell libusb its vendor/product/serial strings. This may be the answer to such issues as networkupstools#1925, networkupstools#2380 (re-opened), networkupstools#2492 Signed-off-by: Jim Klimov <[email protected]>
I will try, not shure how to use it in Unraid maybe @desertwitch can help with it. |
Converting to draft while this is being tested, so NUT CI won't rebuild it in vain against newer target branch as it evolves. |
@jimklimov i tryed compile for Unraid plugin (slackware) but missed some config file for the plugin but @desertwitch the current plugin maintainer was kindly say he can compile for me the test package , so waiting :) |
Thanks Jim! |
@jimklimov Thanks a lot for your PR ,also Thanks a lot for @desertwitch for kindly compiled for me the package for his plugin. So i can see now : |
in case needs test output:
|
if i understood right it still not recognized good as 9E2000 (presumed) ? btw not sure if related but Unraid 7 beta2 use newer version of libusb |
Also found |
And thanks back for the reports! I'll update the "9E2000" vs. "9E2000i" part, but the "presumed" is what is critical there - libusb and NUT were not able to see the actual model name as per original reports' analysis, assigned "unknown" into that string, and "2000" into the other (seemingly from Lines 1584 to 1609 in 4cd226a
And then my PR changes that discovery into the pretty name of "9E2000 (presumed)" at Line 1155 in 4cd226a
So the root-cause problem is still there, this part from the older log:
As you noted time and again,
|
Yes, that is what i got back then i can run thouse commands again ? i think nothing changed but like i said befor libusb has newver version in Unraid 7 beat1 or i can maybe compile for my 6.11.12 ? |
@jimklimov @desertwitch
|
So that seems like 6 batteries at 12V PbAc nominal, charged to 13.8V which sounds normal. At least the bit from #2380 (comment) is resolved by this change :) I've posted the recap of original complaints in top of this ticket, are those all the missing data points or were there more? |
I've also noted that our earlier exchanges about the
Does your installation have those, and is
And I am still a bit unsure if all the reports from different users were from Unraid, or other systems too? Is container approach somehow implicated (e.g. should such udev rules appear in the host system or not?) Also wondering if the distribution has "quirks" set up which for a long time included
|
I think recap is OK , cant remember more at now . |
…ools#2562] I did not find any actual mentions of plain "9E2000" without an "i", only these: https://www.eaton.com/tr/en-gb/skuPage.9E2000I.html Also prepared for "9E3000i" models while here. Signed-off-by: Jim Klimov <[email protected]>
i think @desertwitch as current plugin developer can say more for it? i got : for
|
OK i got for :
|
In your older debug-data dump from
The "PbAc" string is not hard-coded in any USB HID driver, but comes from the mapping table pointing to So here the query failed for some reason (entry-level device as @arnaudquette-eaton mentioned?) and the |
Assuming the NUT drivers run as |
As a random thought, we do get a lot of info from the device successfully, after assuming it is ours (here by numeric IDs alone) and claiming it:
Perhaps, if the claim did succeed and ID data are |
I think when back then just opened issue the developer for NUT plugin for unraid was other than now @desertwitch that he made a lot for the NUT Plugin |
if you need i can run some commands for checks ? |
this is for :
|
@jimklimov oh now i remember some values from #2492 like |
…or, Product, Serial if NULL, after claiming it by other criteria [networkupstools#2562] Signed-off-by: Jim Klimov <[email protected]>
…Product, Serial if NULL, after claiming it by other criteria [networkupstools#2562] Signed-off-by: Jim Klimov <[email protected]>
Also wanted to mention the NUT plugin working in plain unraid not in container |
Aha, I must have mixed it up with HomeAssistant plugins which are delivered as containers. So, Unraid ones run on same bare-metal as their host OS environment, with no further layers? Good to know :) Posted #2571 with speculative changes for retrying the Vendor, Model and Serial fetching after claiming a device. Can you please give that branch a spin? |
Hello again! |
Do you mean to compile and check it? |
Yes :) |
Sure, just I need to wait for @desertwitch will kindly compile for me or will provide me config file for I will try to compile myself |
…networkupstools#2562] According to networkupstools#2571 (comment) Signed-off-by: Jim Klimov <[email protected]>
…ixl"/"ixlau" [networkupstools#2562] Per networkupstools#2571 (comment) Signed-off-by: Jim Klimov <[email protected]>
…networkupstools#2562] According to networkupstools#2571 (comment) Signed-off-by: Jim Klimov <[email protected]>
…ixl"/"ixlau" [networkupstools#2562] Per networkupstools#2571 (comment) Signed-off-by: Jim Klimov <[email protected]>
Making sense and seems to show improvement, as reviewed in conjunction with proposed changes in #2571. |
…Vendor, Product, Serial if NULL, after claiming it by other criteria [networkupstools#2562]" This reverts commit ad83b70. Signed-off-by: Tormod Volden <[email protected]>
…ce->Vendor, Product, Serial if NULL, after claiming it by other criteria [networkupstools#2562]" This reverts commit ea99f96. Signed-off-by: Tormod Volden <[email protected]>
…Vendor, Product, Serial if NULL, after claiming it by other criteria [networkupstools#2562]" This reverts commit ad83b70. The reverted commit attempted to workaround a string descriptor retrieval issue by retrying after claiming an interface on the device. However, this did not help, and it was later found out that a broken langid descriptor was the root issue all along. Signed-off-by: Tormod Volden <[email protected]>
…ce->Vendor, Product, Serial if NULL, after claiming it by other criteria [networkupstools#2562]" This reverts commit ea99f96. The reverted commit attempted to workaround a string descriptor retrieval issue by retrying after claiming an interface on the device. However, this did not help, and it was later found out that a broken langid descriptor was the root issue all along. Signed-off-by: Tormod Volden <[email protected]>
Also handle "unknown 2000" assuming it is a mis-read "Eaton 9E 2000(i?)" which refused to tell libusb its vendor/product/serial strings. Although note that if we were not able to read basic identification data, chances of really interacting with the device are... sketchy.
This may be the answer to such issues as #1925, #2380 (re-opened), #2492
To recap, reported issues were (at least):
device.model
andups.model
nut_libusb_open()
, even when NUT runs asroot
(but maybe is somehow restricted being in a container?)lsusb
on the same box, byudevadm info
, and byapcupsd
it seemsbattery.type
is present but has no valueThe PR is more or less a guess-work based on earlier comments from @arnaudquette-eaton in those issue discussions.
CC @masterwishx @loso2255 @lemeshovich : would you be able to try a custom build of NUT following https://github.com/networkupstools/nut/wiki/Building-NUT-for-in%E2%80%90place-upgrades-or-non%E2%80%90disruptive-tests to see if it handles the devices better? A couple of things I'd be interested in is if it can recognize the device properly (as "9E2000" or "9E2000i", not "9E2000 (presumed)"), and if it serves the
battery.voltage
(current and nominal).For the git checkout, use this PR's source branch: