-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing values for ECO Mode Eaton #2620
Conversation
… for Eaton Signed-off-by: DaRK AnGeL <[email protected]>
…ansfer.frequency.eco) Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: DaRK AnGeL <[email protected]>
@jimklimov @arnaudquette-eaton i hope this can be the first step to way to enable ECO Mode for Eaton ?!? |
Currently the added name patterns are missing in Somewhat orthogonal to this PR, there seems to be no mix of "frequency" and "transfer" in the naming yet. The existing There are however Regarding your tests, I did not understand why Also, an explanation (in |
I just named with |
Yes it's adding 6 missing values of bypass/eco |
Also found
Yes you are right , it seems , its input.transfer.frequency.bypass.range: 10%
i have only :
|
yes Maybe you right |
or better (Hz[%]) ? |
@jimklimov can i add also : input.transfer.hysteresys = 10V HysteresysVoltageTransfer
|
Signed-off-by: DaRK AnGeL <[email protected]>
Well, a physicist bit of me screamed inside at the idea of "percent" (a fraction, so no measurement types as they cancel out during division) and a type (Hz) being together in one term. But lay-manly, it sort of makes sense. Still, I think something like "10% of nominal (voltage/frequency/etc...)" is less ambiguous. |
Knowing the Hysteresys setting sounds fun; the large description maybe fits into the |
is it ok in description ? |
Signed-off-by: DaRK AnGeL <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
I've posted a couple of commits with asciidoc fixes, gotta check how the resulting rendered files look, too. Don't overwrite them when pushing out your future changes, if any ( FWIW, now I've also noted that you made the PR from your copy of the That hysteresys article, where did it come from? (Maybe attribution is in order, at least in commit comment when/if you add it) |
OK sorry ,im only learning really using git : ) |
If you want to continue in this area, I can strongly suggest the Atlassian Git tutorial, it was quite a good ramp-up back in the day when I trained some colleagues on Git. Nowadays there are also quite a few "gamified" manuals/trainings, where you solve certain goals in a provided repo to find the next tasks to do, etc. Some friends reported that such approach helped them a lot. |
maybe better ?
|
This is from Copilot Win 11 |
Maybe better. Note the extra |
Ah, it got us: "hysteresis" not "hysteresys" :D |
I'll post the fixes in a minute |
im moved to another branch and now confused with pr tom merge it :( |
Signed-off-by: Jim Klimov <[email protected]>
…etworkupstools#2620] Signed-off-by: Jim Klimov <[email protected]>
…tion [networkupstools#2620] Signed-off-by: Jim Klimov <[email protected]>
…tworkupstools#2620] Signed-off-by: Jim Klimov <[email protected]>
So, we are not the first to make that typo :)
|
I think with this particular PR, we can finish here. Seems almost done. |
✅ Build nut 2.8.2.2142-master completed (commit 95fcc5ec79 by @jimklimov) |
@jimklimov Cool, can be merged now;) Another question for the future work is what values we should have to enable Bypass/ECO |
Fixes #2492
Add missing values for ECO and Bypass mode for Eaton for future work for enable ECO mode.
compiled and checked in NUT Plugin in unraid :
compiled and checked with:
input.transfer.frequency.bypass.high
andinput.transfer.frequency.eco.high
after changed to :
input.transfer.frequency.bypass.range
input.transfer.frequency.eco.range
in values :
Reduced here text for :
range
also insteadhigh
for not compile again ...