Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallout of #2671 and complete the feature with optional interrupt_pipe_no_events_tolerance setting #2682

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Fix fallout of #2671 and complete the feature with optional interrupt_pipe_no_events_tolerance setting #2682

merged 2 commits into from
Nov 17, 2024

Conversation

jimklimov
Copy link
Member

Now users of devices that can be caught hanging out and slacking off by a continuous stream of "Got 0 HID Objects" from interrupts can configure a toggle to say how much is enough, and reconnect the driver. Legacy default is to not bother, and assume the device just has nothing to urgently report.

Closes: #2681
Follow-up to: #2671

CC for testing: @desertwitch @masterwishx @michal4132

@jimklimov
drivers/usbhid-ups.c: fix fallout of networkupstools#2671 and complet…
8fe9e46 
…e the feature with optional `interrupt_pipe_no_events_tolerance` setting [networkupstools#2681]

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov
drivers/usbhid-ups.c: report unhandled negative HIDGetEvents() return…
61c4053 
… values [networkupstools#2681]

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov jimklimov added bug APC USB Connection stability issues Issues about driver<->device and/or networked connections (upsd<->upsmon...) going AWOL over time labels Nov 16, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Nov 16, 2024
@masterwishx
Copy link
Contributor

masterwishx commented Nov 17, 2024 •
edited
Loading

Now users of devices that can be caught hanging out and slacking off by a continuous stream of "Got 0 HID Objects" from interrupts can configure a toggle to say how much is enough, and reconnect the driver. Legacy default is to not bother, and assume the device just has nothing to urgently report.

Closes: #2681 Follow-up to: #2671

CC for testing: @desertwitch @masterwishx @michal4132

Thanks a lot, checked working fine!

Nov 17 09:29:40 server usbhid-ups[24060]: [D1:24060] upsdrv_updateinfo...
Nov 17 09:29:40 server usbhid-ups[24060]: [D2:24060] nut_libusb_get_interrupt: Connection timed out
Nov 17 09:29:40 server usbhid-ups[24060]: [D1:24060] Got 0 HID objects (340 times in a row, tolerance is -1)...
Nov 17 09:29:40 server usbhid-ups[24060]: [D1:24060] Quick update...
Nov 17 09:29:40 server usbhid-ups[24060]: [D4:24060] Entering libusb_get_report

also new var avaible :)

driver.parameter.interrupt_pipe_no_events_tolerance = -1

@desertwitch
Copy link
Contributor

LGTM - thanks!

@jimklimov
Copy link
Member Author

jimklimov commented Nov 17, 2024 •
edited
Loading

Cool, thanks for testing and sorry for the mishap :)

@jimklimov jimklimov merged commit 53a83f6 into networkupstools:master Nov 17, 2024
30 checks passed
@jimklimov jimklimov deleted the issue-2681 branch November 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertwitch desertwitch desertwitch approved these changes

Assignees
No one assigned
Labels
APC bug Connection stability issues Issues about driver<->device and/or networked connections (upsd<->upsmon...) going AWOL over time USB
Projects
None yet
Milestone
2.8.3
Development

Successfully merging this pull request may close these issues.

Eaton 9E Reconnect broke NUT plugin for Unraid by Fix #2671
3 participants
@jimklimov @masterwishx @desertwitch