Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

make venv input optional #369

Closed
wants to merge 2 commits into from
Closed

Conversation

derekk-nm
Copy link

@derekk-nm derekk-nm commented Jul 8, 2024

the venv input assigned to some actions has not been set in a variety of workflows, in spite of it being required.
In fact, the actions already have code to check the value and provide a reasonable substitute for it if it wasn't provided.
I've;

  • modified the input declaration to indicate that it is optional,
  • with a default empty string value, and
  • removed the references to it from workflows that were passing in blank values.

I also updated the nm-lm-eval action to use the same pattern to test the value of the venv input, so that it is consistent with the other actions.

This nm remote push run demonstrates that at least the nm-test workflow and called actions continues to work as expected.

where appropriate.  Use it consistently in different actions.
Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look okay, but wondering if we should just remove it entirely. we don't really use it anymore.

@derekk-nm
Copy link
Author

@andy-neuma , just to confirm, you're saying that we don't really need to be using virtual environments in these actions? So I can just remove the if block altogether, right?
Or are you saying that we should always just use a virtual env constructed with the COMMIT id? pull the content of the if block into the same level as the rest of the shell command?

@andy-neuma
Copy link
Member

@derekk-nm - i'm suggesting we just remove the venv usage. you can just delete the "if" block.

Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Per discussion in the PR and standup, since we're using the setup-python action in an earlier step of workflows where these actions were called, we don't need to be using any python virtual environments.
@derekk-nm
Copy link
Author

Thanks @andy-neuma, I had a patch ready that deleted the if blocks, so I've pushed here. will wait for the checks to complete.

@derekk-nm
Copy link
Author

moving to nm-vllm-ent

@derekk-nm derekk-nm closed this Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants