SparseML dependency on compressed-tensors
#2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
changed the title
sparsetensorssparsetensors
bfineran
suggested changes
Apr 8, 2024
There was a problem hiding this comment.
biggest thing I'd like to talk through with you and @Satrat is moving the actual configs into sparsetensors. specifically having configs take in the sparsification structure as an input so we don't need to couple the analysis code with the config classes
dbogunowicz
changed the title
sparsetensorssparsetensors
|
@bfineran @dbogunowicz is there anything blocking this from being merged?? |
|
@Satrat I'd say the readiness of the pypi package. This PR is currently compatible with the |
|
@dbogunowicz @Satrat I would also mention pydantic v2 support as a blocker #2248 |
dbogunowicz
changed the title
sparsetensorscompressed-tensors
…/sparseml into feature/damian/sparsetensors
rahul-tuli
previously requested changes
Apr 24, 2024
|
|
Co-authored-by: Rahul Tuli <[email protected]>
dbarbuzzi
reviewed
Apr 25, 2024
bfineran
previously approved these changes
Apr 29, 2024
Satrat
previously approved these changes
Apr 29, 2024
Satrat
approved these changes
Apr 30, 2024
rahul-tuli
approved these changes
Apr 30, 2024
bfineran
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA will be green after: https://github.com/neuralmagic/compressed-tensors/pulls lands