Use more nanobind API #3024
Merged
Use more nanobind API #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ 0ddcaa4 -> Azure artifacts URL |
mgeplf
reviewed
Jul 31, 2024
This comment has been minimized.
This comment has been minimized.
ferdonline
changed the title
1uc
reviewed
Jul 31, 2024
1uc
reviewed
Jul 31, 2024
|
✔️ 1aa2de8 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
ferdonline
changed the title
|
✔️ 7dc294a -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3024 +/- ##
==========================================
- Coverage 67.28% 67.27% -0.01%
==========================================
Files 572 572
Lines 104945 104939 -6
==========================================
- Hits 70607 70602 -5
+ Misses 34338 34337 -1 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
🥳 |
ferdonline
force-pushed
the
enh/py_bind/nb_api_more
branch
from
2fa061d
to
76305ff
Compare
|
✔️ 76305ff -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
1uc
previously approved these changes
Aug 5, 2024
1uc
reviewed
Aug 5, 2024
1uc
reviewed
Aug 5, 2024
ferdonline
force-pushed
the
enh/py_bind/nb_api_more
branch
from
76305ff
to
c526b7f
Compare
|
|
✔️ c526b7f -> Azure artifacts URL |
1uc
approved these changes
Aug 7, 2024
mgeplf
pushed a commit
that referenced
this pull request
Aug 19, 2024
Use nanobind to simplify the implementation of: * `NpySObj_contains`, * `NPySecObj_insert`, * `seg_point_processes`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Use nanobind API to further simplify operations and correct ref count.
This PR
nb::listandnb::handleAPI to simplify operationsnb::stealto track a new reference returned byPyObject_CallMethod(tpyobj, "insert".inc_ref()to an object being returned