Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Git version check for --depth option in submodule update #3032

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jorblancoa
Copy link
Contributor

@jorblancoa jorblancoa requested a review from 1uc August 6, 2024 15:35
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thank you.

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

✔️ 2dded8c -> Azure artifacts URL

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (bd5400b) to head (2dded8c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3032   +/-   ##
=======================================
  Coverage   67.27%   67.28%           
=======================================
  Files         572      572           
  Lines      104928   104921    -7     
=======================================
+ Hits        70591    70593    +2     
+ Misses      34337    34328    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ferdonline
Copy link
Member

Does this supersedes #2980 ?

@jorblancoa
Copy link
Contributor Author

Does this supersedes #2980 ?

Yes! Didn't see that one. I guess we can close #2980 then?

@1uc 1uc merged commit 514efd6 into master Aug 7, 2024
38 checks passed
@1uc 1uc deleted the jblanco/submodule_depth_check branch August 7, 2024 08:16
mgeplf pushed a commit that referenced this pull request Aug 19, 2024
On certain old OSes (commonly found on clusters), the installed Git
version doesn't support `--depth`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants