Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script to handle uncompressed niftii files #100

Merged
merged 11 commits into from
Jan 13, 2025
Merged

Conversation

NathanMolinier
Copy link
Collaborator

Description

The aim of this PR is to allow the use of uncompressed niftii files.

Related issue

#57

@NathanMolinier NathanMolinier requested a review from yw7 January 7, 2025 10:00
Copy link
Collaborator

@yw7 yw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NathanMolinier for this greate work!!
I didn't notice any issues with the code, but I didnt have time to test it yet.
Did you test with single/multiple inputs? also with and without localizer (also with single and multiple inputs)?

@NathanMolinier
Copy link
Collaborator Author

Yes I tested with all the different combinations including:

  • Folder input and file input
  • Folder input with localizer folder and file input with localizer input

Hope I did not miss anything

@NathanMolinier NathanMolinier merged commit d93adc6 into main Jan 13, 2025
@NathanMolinier NathanMolinier deleted the nm/57_allow_nii branch January 13, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants