sparsEDA integration #966
Merged
sparsEDA integration #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input was resampled to 8Hz as required by sparsEDA, but the padded signalAdd variable that is actually used was assigned before resampling.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #966 +/- ##
==========================================
+ Coverage 54.59% 55.93% +1.34%
==========================================
Files 304 304
Lines 14325 14325
==========================================
+ Hits 7821 8013 +192
+ Misses 6504 6312 -192 ☔ View full report in Codecov by Sentry. |
|
The documentation check fails somewhere unrelated to this PR |
|
Thanks a lot for this @stasinos and sorry I've been away from NK for some time, will review this asap! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sparsEDA algorithm detects the tonic component in EDA and returns: a
driver,SCL(tonic component), andMSE(residual). This is incompable witheda_phasic()which expects a(tonic,phasic)pair, see also Issue #964 .This PR resolves Issue #964 by making
_eda_phasic_sparsEDA()return a(tonic,phasic)pair wheretonicisSCLandphasicis the difference between the original signal and the tonic component detected by sparsEDA,