Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wavelength cropping of input neutron data used during normcal workflow #543

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

mguthriem
Copy link
Collaborator

Description of work

At low and high wavelength ends of the spectral data in each neutron dataset, the background increases steeply. This is attributed to blade edge effects on the instrument choppers.

If the events in this high background region aren't removed, the result is increased background at the edge of the diffraction-focused data in SNAPRed. This cannot be fixed with existing d-space cropping options

This PR enables the removal of these events during Normcal. Future related
work should enable identical treatment of sample neutron data used during reduction.

Explanation of work

The gist of this work is to use mantid CropWorkspace to remove the problematic events using as input parameters existing SNAPRed parameters that delineate max and min wavelength range.

What is missing from this work is any assessment of impact on unit tests, or attempt to address this.

To test

Dev testing

CIS testing

CIS and IS have already tested the output of this PR and found it solves the issue.

Link to EWM item

This PR arose during prototyping not captured in EWM.

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

All events outside SNAPRed calculated wavelength limits are removed prior to saving of output raw vanadium correction.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.37%. Comparing base (9eb99a8) to head (d914c9b).
Report is 4 commits behind head on next.

❗ There is a different number of reports uploaded between BASE (9eb99a8) and HEAD (d914c9b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9eb99a8) HEAD (d914c9b)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             next     #543       +/-   ##
===========================================
- Coverage   95.98%   48.37%   -47.62%     
===========================================
  Files          68       68               
  Lines        5152     5160        +8     
===========================================
- Hits         4945     2496     -2449     
- Misses        207     2664     +2457     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant