Add wavelength cropping of input neutron data used during normcal workflow #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
At low and high wavelength ends of the spectral data in each neutron dataset, the background increases steeply. This is attributed to blade edge effects on the instrument choppers.
If the events in this high background region aren't removed, the result is increased background at the edge of the diffraction-focused data in SNAPRed. This cannot be fixed with existing d-space cropping options
This PR enables the removal of these events during Normcal. Future related
work should enable identical treatment of sample neutron data used during reduction.
Explanation of work
The gist of this work is to use mantid
CropWorkspace
to remove the problematic events using as input parameters existing SNAPRed parameters that delineate max and min wavelength range.What is missing from this work is any assessment of impact on unit tests, or attempt to address this.
To test
Dev testing
CIS testing
CIS and IS have already tested the output of this PR and found it solves the issue.
Link to EWM item
This PR arose during prototyping not captured in EWM.
Verification
Acceptance Criteria
All events outside SNAPRed calculated wavelength limits are removed prior to saving of output raw vanadium correction.