Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre commit #607

Merged
merged 27 commits into from
Feb 11, 2025
Merged

Update pre commit #607

merged 27 commits into from
Feb 11, 2025

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Dec 18, 2024

Short description of the changes:

  • Update .pre-commit-config.yaml and pyproject.toml to ignore notebooks
  • Switch to ruff format to be in line with neutrons python project template
  • run ruff formatting
  • manually address lint errors or add noqa: comments where sensible to avoid changing functioning logic too much

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • [n/a] I have added tests for my changes
  • [n/a] I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@glass-ships glass-ships requested a review from jmborr January 29, 2025 17:39
jmborr
jmborr previously requested changes Jan 29, 2025
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to undo the changes to the python notebooks because I doubt very much the linters are supposed to change that

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 58.49057% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.09%. Comparing base (3892a8a) to head (5197bb1).
Report is 3 commits behind head on next.

Files with missing lines Patch % Lines
src/drtsans/mono/biosans/api.py 0.00% 3 Missing ⚠️
src/drtsans/mono/gpsans/api.py 0.00% 3 Missing ⚠️
src/drtsans/detector.py 0.00% 2 Missing ⚠️
src/drtsans/files/log_h5_reader.py 0.00% 2 Missing ⚠️
src/drtsans/pixel_calibration.py 77.77% 2 Missing ⚠️
src/drtsans/tof/eqsans/correction_api.py 0.00% 2 Missing ⚠️
src/drtsans/determine_bins.py 0.00% 1 Missing ⚠️
src/drtsans/geometry.py 0.00% 1 Missing ⚠️
src/drtsans/mono/spice_data.py 0.00% 1 Missing ⚠️
src/drtsans/path.py 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #607      +/-   ##
==========================================
- Coverage   86.18%   86.09%   -0.10%     
==========================================
  Files          98       97       -1     
  Lines       10760    10742      -18     
==========================================
- Hits         9274     9248      -26     
- Misses       1486     1494       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glass-ships glass-ships requested a review from jmborr February 6, 2025 19:39
@glass-ships glass-ships enabled auto-merge (squash) February 6, 2025 19:44
Copy link
Contributor Author

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and approve. However, I can't approve since I opened the PR (but I did none of the work). @jmborr would you mind clicking the approve button for me?

@glass-ships glass-ships dismissed jmborr’s stale review February 11, 2025 17:32

Changes were made

@glass-ships glass-ships merged commit d88ea02 into next Feb 11, 2025
2 checks passed
@glass-ships glass-ships deleted the update-pre-commit branch February 11, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants