-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre commit #607
Update pre commit #607
Conversation
updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.4.0...v5.0.0) - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.0.275 → v0.8.3](astral-sh/ruff-pre-commit@v0.0.275...v0.8.3) - [github.com/psf/black: 23.3.0 → 24.10.0](psf/black@23.3.0...24.10.0) - [github.com/kynan/nbstripout: 0.6.1 → 0.8.1](kynan/nbstripout@0.6.1...0.8.1)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to undo the changes to the python notebooks because I doubt very much the linters are supposed to change that
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #607 +/- ##
==========================================
- Coverage 86.18% 86.09% -0.10%
==========================================
Files 98 97 -1
Lines 10760 10742 -18
==========================================
- Hits 9274 9248 -26
- Misses 1486 1494 +8 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this PR and approve. However, I can't approve since I opened the PR (but I did none of the work). @jmborr would you mind clicking the approve button for me?
Short description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References