handle other exceptions in the popup window #11
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llib3.exceptions.NameResolutionError when there is no internet connection
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #11 +/- ##
==========================================
+ Coverage 95.07% 95.20% +0.13%
==========================================
Files 3 3
Lines 142 146 +4
==========================================
+ Hits 135 139 +4
Misses 7 7 ☔ View full report in Codecov by Sentry. |
tests/test_login_dialog.py
Outdated
| # This is the error message that crashed Shiver when there is no internet connection | ||
| dialog.show_message.assert_called_once_with( | ||
| "The following exception occured: NameResolutionError.__init__() missing 3 \ | ||
| required positional arguments: 'host', 'conn', and 'reason'" |
There was a problem hiding this comment.
too many spaces. It fails the test
AndreiSavici
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shiver crashes user tries to login without internet connection. This exception was raised "llib3.exceptions.NameResolutionError" which is not handled. This pr adds a blanket exception handling to display the exception in the pop up window.
EWM 9859
Fixed unit tests to correctly test difference use cases
Short description of the changes:
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References