Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent libarchive version #13

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Consistent libarchive version #13

merged 7 commits into from
Mar 26, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Mar 25, 2024

Short description of the changes:

A conda environment containing dependencies from different channels (mantid, conda-forge, defaults) often leads to the following error when trying to build the conda package:

from libmambapy.bindings import *  # noqa: F401,F403
ImportError: libarchive.so.19: cannot open shared object file: No such file or directory

Long description of the changes:

  • Explicit requirements of libmamba and libarchive so that both will be installed from the same conda channel.
  • commented out build conda package in the unittest workflow. We should be testing the conda package even though we won't publish it
  • add dependency anaconda-client to ensure command anaconda is available and prevent this error when uploading a conda package just built

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@jmborr jmborr self-assigned this Mar 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.70%. Comparing base (6306d9b) to head (8d4686c).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #13   +/-   ##
=====================================
  Coverage   3.70%   3.70%           
=====================================
  Files          5       5           
  Lines        135     135           
=====================================
  Hits           5       5           
  Misses       130     130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr requested a review from KedoKudo March 25, 2024 23:35
Copy link
Member

@KedoKudo KedoKudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KedoKudo KedoKudo merged commit b1874ac into main Mar 26, 2024
2 checks passed
@KedoKudo KedoKudo deleted the libarchive_resolution branch March 26, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants