-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(application_settings): amp application settings to sync with the latest released/available features/functionalities in apm settings ui #1267
Conversation
0c0f1de
to
7bd5f6d
Compare
11c1e53
to
27a1df4
Compare
27a1df4
to
114b5a6
Compare
…and reverted lint spelling changes
@vinay-newrelic all good here, except for one question (just adding it here for the record) - I think we'd discussed sometime that you intend to move the mutation to update application settings into a new/different package to avoid type conflicts, etc. Do you think that is still needed, or are we good with the current arrangement? I don't think there's anything incorrect, but would just like to double check |
@pranav-new-relic Just thought of moving it to seperate package since the current apm package is a but messy and overloaded but then realised agent applications pkg is the one which already has this schema and mutations which is also pretty organised.shifting it under APM package again would result in redundancy and introduce confusion. |
3df10d6
to
7ed74ad
Compare
chore: tiny fix
ae66b7e
to
2806382
Compare
All good 👍 we're good to go |
Right now, this TF resource only supports a subset of the application settings available on the APM UI .
This PR concludes the changes required for
newrelic_application_settings
resource to add the missing set of configuration settings that are available on the UI