Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application_settings): amp application settings to sync with the latest released/available features/functionalities in apm settings ui #1267

Merged
merged 7 commits into from
Mar 10, 2025

Conversation

vinay-newrelic
Copy link
Contributor

@vinay-newrelic vinay-newrelic commented Jan 30, 2025

Right now, this TF resource only supports a subset of the application settings available on the APM UI .
This PR concludes the changes required for newrelic_application_settings resource to add the missing set of configuration settings that are available on the UI

@vinay-newrelic vinay-newrelic marked this pull request as draft January 30, 2025 06:09
@vinay-newrelic vinay-newrelic marked this pull request as ready for review February 11, 2025 16:12
@vinay-newrelic vinay-newrelic changed the title draft pr changes feat(application_settings): amp application settings to sync with the latest released/available features/functionalities in apm settings ui Feb 11, 2025
@pranav-new-relic pranav-new-relic force-pushed the NR-343240 branch 2 times, most recently from 11c1e53 to 27a1df4 Compare March 4, 2025 10:07
@pranav-new-relic
Copy link
Member

pranav-new-relic commented Mar 4, 2025

@vinay-newrelic all good here, except for one question (just adding it here for the record) - I think we'd discussed sometime that you intend to move the mutation to update application settings into a new/different package to avoid type conflicts, etc. Do you think that is still needed, or are we good with the current arrangement? I don't think there's anything incorrect, but would just like to double check

@vinay-newrelic
Copy link
Contributor Author

@vinay-newrelic all good here, except for one question (just adding it here for the record) - I think we'd discussed sometime that you intend to move the mutation to update application settings into a new/different package to avoid type conflicts, etc. Do you think that is still needed, or are we good with the current arrangement? I don't think there's anything incorrect, but would just like to double check

@pranav-new-relic Just thought of moving it to seperate package since the current apm package is a but messy and overloaded but then realised agent applications pkg is the one which already has this schema and mutations which is also pretty organised.shifting it under APM package again would result in redundancy and introduce confusion.

@pranav-new-relic
Copy link
Member

All good 👍 we're good to go

@nr-developer-toolkit nr-developer-toolkit merged commit ac6373d into main Mar 10, 2025
11 of 12 checks passed
@nr-developer-toolkit nr-developer-toolkit deleted the NR-343240 branch March 10, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants