feat: add Integration Version to Inventory Payload #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/definition/populate.go
Outdated
| @@ -12,6 +12,7 @@ import ( | |||
|
|
|||
| const NamespaceGroup = "namespace" | |||
| const NamespaceFilteredLabel = "nrFiltered" | |||
| const integrationName = "com.newrelic.kubernetes" | |||
There was a problem hiding this comment.
Can you make it to IntegrationName so that it is available outside the package like the other Namespace related constants.
There was a problem hiding this comment.
Or move it to where integrationVersion is defined?
ramkrishankumarN
previously approved these changes
Jan 10, 2025
ramkrishankumarN
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add K8s Integration Version to Inventory
NR-332888
Type of change
Checklist: