Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Essex_Hog, update authentication docs #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valentijnscholten
Copy link

@valentijnscholten valentijnscholten commented Jan 11, 2023

To authenticate to Confluence Server or Datacenter using a PAT (Personal Access Token) (Bearer token), it should NOT be base64 encoded.

See https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html

This was already working for JIRA/Gottingenhog, but not yet for Confluence/Essexhog.

I also made sure all variables in EssexHog are named confluencexxxx to avoid any confusion with GottingenHog.

Ideally the authentication is extracted into a shared piece of code ("atlassian auth"), but since this is my first Rust code change ever, I didn't dare to go that way :-)

Updated docs a little bit as well to help people deciphering the differences between Cloud and Server/Datacenter authentication which are handling the PATs differently.

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@valentijnscholten valentijnscholten changed the title Fix Confluence server/datacenter authentication Cleanup Essex_Hog, update authentication docs Jan 11, 2023
@valentijnscholten
Copy link
Author

Looks like the base64 fix was already added a long time ago. I missed that as I was looking at the source of the latest release v1.0.11 which does not contain that fix yet. Time for a new release?

@cutler-scott-newrelic
Copy link
Contributor

Hi @valentijnscholten , I can work on a release this week, but without Github actions I don't think I'll be able to produce many binaries other than what I can make on my own work laptop. As for this PR, thanks for the work and cleanup, much appreciated. Is this PR still valid and synced with the latest changes in master? If so I can merge it before issuing the release. (My only problem is that I may not be able to test it on my employer's confluence server.)

@valentijnscholten
Copy link
Author

Yes it's up-to-date and contains no code changes, just naming and docs.

@valentijnscholten
Copy link
Author

Looks like previous releases were done manually as well via [build_ghrelease.sh](https://github.com/newrelic/rusty-hog/blob/master/build_ghrelease.sh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants