-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): Add prediction support to NRQL alert conditions #2816
feat(alerts): Add prediction support to NRQL alert conditions #2816
Conversation
A note for the reviewer: |
👀 👀 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
- Coverage 32.82% 31.06% -1.76%
==========================================
Files 98 102 +4
Lines 26884 27602 +718
==========================================
- Hits 8824 8574 -250
- Misses 17902 18858 +956
- Partials 158 170 +12 ☔ View full report in Codecov by Sentry. |
chore: revert test on forks, inconsistent behaviour
2ac68ad
to
60f31d5
Compare
Tested multiple cases of Baseline and Static NRQL Alert Conditions, with and without this attribute. All should be good. The test cases in the NRQL Alert Condition resource are also running fine. |
Description
prediction
fields on NRQL alert conditionsprediction
field is only available for static NRQL conditions (not baseline/anomaly conditions)Type of change
Checklist:
How to test this change?
For an account that is current added to the feature flag:
prediction
fieldprediction
field