Add error types, stop returning strings #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Newsboat, we relay the error to the user, but other people might want to do other things. This commit replaces `String`s with two new types, one for `new()` and one for `matches()`. Even though they are identical, I decided to have two of them because in the future they might become slightly different. (I don't foresee that, as the underlying API has been stable for decades, but if it ever happens I'd be glad I did it this way.) As a result, we can drop dependencies on `gettext-rs` and `strprintf`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Newsboat, we relay the error to the user, but other people might want to do other things. This commit replaces
Strings with two new types, one fornew()and one formatches(). Even though they are identical, I decided to have two of them because in the future they might become slightly different. (I don't foresee that, as the underlying API has been stable for decades, but if it ever happens I'd be glad I did it this way.)As a result, we can drop dependencies on
gettext-rsandstrprintf.@dennisschagt, @exaroth, I asked you for review primarily because I want your opinion on the names I picked :) I'd also appreciate feedback on the shape of the API; can you imagine using this outside Newsboat?