Ensure device symmetricNAT field is updated #1957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nexodus-docs canceled.
|
vishnoianil
force-pushed
the
symnat-flag
branch
3 times, most recently
from
3345ba5 to
16ecc0f
Compare
with add/update device requests Openapi client generates the model with json tag omitempty, that removes the symmetricNAT flag in the json request body if it's false. Signed-off-by: Anil Kumar Vishnoi <[email protected]>
|
I don't think this will fix the problem. The issue is in the generated OpenAPI client models. |
russellb
reviewed
Mar 6, 2024
| When I PATCH path "/api/devices/${device_id}" with json body: | ||
| """ | ||
| { | ||
| "symmetric_nat": false |
There was a problem hiding this comment.
In my testing, this was not present in the request at all
There was a problem hiding this comment.
Yeah.. this PR changes AddDevice model, but that's not used in the PATCH operation.
|
fixed in #1958` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with add/update device requests
Openapi client generates the model with json tag
omitempty, that removes the symmetricNAT flag in
the json request body if it's false.
Fixes: #1956