-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording in aio-config.twig #4660
base: main
Are you sure you want to change the base?
Conversation
Small improvements to text. No code changes. Signed-off-by: ncguk <[email protected]>
You can run Nextcloud's usual occ commands by following the <a href="https://github.com/nextcloud/all-in-one#how-to-run-occ-commands">occ documentation</a></b>.<br><br> | ||
{% endif %} | ||
|
||
{% if nextcloud_datadir starts with '/' %} | ||
Nextcloud's datadir is getting stored in the {{ nextcloud_datadir }} directory. | ||
Nextcloud's datadir is stored in the {{ nextcloud_datadir }} directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just one remark:
Actually, during the initial installation, the data is not stored yet. Only after finishing it. That is why this kind of wording was chosen. What would you suggest to improve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I would suggest then that the wording be "Nextcloud's datadir will be stored in the {{ nextcloud_datadir }} directory."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm... I fear this doesnt work after the instance is installed then? (this template is used in both cases...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I see what you mean.
"Nextcloud backups will be saved to {{ nextcloud_datadir }}." works for both a first back up and subsequent backups that have yet to be made. You could also have:
"All Nextcloud backups will be saved to {{ nextcloud_datadir }}."
"Your Nextcloud backups will be saved to {{ nextcloud_datadir }}."
"All of your Nextcloud backups will be saved to {{ nextcloud_datadir }}."
"Once you have made your first backup it, and all subsequent backups, will be stored in {{ nextcloud_datadir }}."
Small improvements to text. No code changes.