🔧 Refactor manual-install Compose.yml: Simplify Environment Variables #5393
Conversation
- Removed explicit values for environment variables in `docker-compose.yml`. - Utilized default values for better flexibility and maintainability. - Updated network configuration to use the default bridge driver. Note: Using `network: default` is sufficient within Docker Compose; there's no need to create a separate `nextcloud-network` for all hosts. 🚀 Signed-off-by: lll <[email protected]>
There was a problem hiding this comment.
File is created via script: https://github.com/nextcloud/all-in-one/blob/main/manual-install/update-yaml.sh - you need to modify the script not the file
Co-authored-by: Jean-Yves <[email protected]> Signed-off-by: lll <[email protected]>
Co-authored-by: Jean-Yves <[email protected]> Signed-off-by: lll <[email protected]>
`update-yaml.sh`の処理の追加を - .services[].networks の削除 - =%%を削除する特殊な処理 これにより、 すべてのサービスをdefaultのネットワークに接続させることができ、 変数の簡略化が見込めます Signed-off-by: lll <[email protected]>
|
Thank you for your reviews, Zoey2936, docjyJ, and szaimen. I've made additional changes to the
Additionally, I've corrected the REDIS_HOST_PASSWORD variable. Thank you all for your valuable input and contributions. |
szaimen
added
3. to review
Signed-off-by: lll <[email protected]> Co-Authored-By: Jean-Yves <[email protected]>
|
Hi @flll thanks a lot for this contribution! I've just invited you to the repo so that collaboration is easier :) |
|
The changes look good in general, but I fear there is another script that needs to be adjusted. See https://github.com/nextcloud/all-in-one/blob/main/nextcloud-aio-helm-chart/update-helm.sh I've for easier testing pushed your changes to a local branch: #5459 After accepting my invite to the repo, you can then go to https://github.com/nextcloud/all-in-one/actions/workflows/update-helm.yml and click the Run workflow button and select the enh/5393/local-branch branch to test your changes. See The changes are then going to be pushed to #5458 |
|
Thank you very much. I apologize for the trouble I've caused you. Once again, thank you for your assistance. |
|
Merged in #5459. Thanks a lot for tackling this and not giving up! 😊 |
docker-compose.yml.Note: Using
network: defaultis sufficient within Docker Compose; there's no need to create a separatenextcloud-networkfor all hosts. 🚀