-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "port" to borg remote placeholder #5792
Conversation
Signed-off-by: airo.pi_ <[email protected]>
f2d40c7
to
12fddf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @AiroPi but there are some additional places where this should be fixed: https://github.com/search?q=repo%3Anextcloud%2Fall-in-one%20ssh%3A%2F%2Fuser%40host%3A%2Fpath%2Fto%2Frepo&type=code |
Oops, you're right. I will fix the url at these places asap 👍 |
Signed-off-by: Pierre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks :)
This is now released with v10.3.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
The current placeholder is confusing :
ssh://user@host:/path
is wrong (for example,ssh://[email protected]:/mnt/borg
will raise an error).It should either be
ssh://user@host/path
orssh://user@host:port/path
for more clarity.