Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add calcardbackup community container #5864

Merged
merged 4 commits into from
Jan 14, 2025
Merged

add calcardbackup community container #5864

merged 4 commits into from
Jan 14, 2025

Conversation

pailloM
Copy link
Collaborator

@pailloM pailloM commented Jan 11, 2025

Add calcardbackup - follow-up on discussion #3696

I would have liked to test this locally. I have not been able to find any documentation to do that. I you can send me link I would be happy to do that.

@szaimen
Copy link
Collaborator

szaimen commented Jan 13, 2025

Hi, thanks a lot for your PR @pailloM! :)

You can test this by mounting the file inside the mastercontainer inside this folder /var/www/docker-aio/community-containers via e.g. -v ./calcardbackup:/var/www/docker-aio/community-containers/calcardbackup/ and then activate the container via --env AIO_COMMUNITY_CONTAINERS="calcardbackup" during the docker run command.

Let me know if you need any further help on this :)

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Jan 13, 2025
@szaimen szaimen added this to the next milestone Jan 13, 2025
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already quite good, thanks a lot! :)

Some small comments below...

community-containers/calcardbackup/readme.md Outdated Show resolved Hide resolved
community-containers/calcardbackup/calcardbackup.json Outdated Show resolved Hide resolved
@szaimen szaimen changed the title add calcardbackup community container - initial commit add calcardbackup community container Jan 13, 2025
@pailloM
Copy link
Collaborator Author

pailloM commented Jan 14, 2025

I have tested it as per your recommendation and it seems to work fine. It ran on startup and found all the calendars, all the address books and created an archive in the backup folder!
I have not tested the backup files though

Signed-off-by: Simon L. <[email protected]>
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 14, 2025
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot! 😊

@szaimen szaimen merged commit ce7a10e into nextcloud:main Jan 14, 2025
4 checks passed
@szaimen
Copy link
Collaborator

szaimen commented Jan 14, 2025

@pailloM I just invited you to the repo for easier collaboration in the future ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants