Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend OCCapability to include notes folder location #1665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Feb 5, 2025

With this change, the android library will now be able to determine the folder where notes are stored. This will be used to determine when to display a Open in Notes button in the files client according to nextcloud/notes-android#1873.

Requires nextcloud/notes#1468

@ZetaTom ZetaTom self-assigned this Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 22.72%. Comparing base (e3c0611) to head (ad0eb99).

Files with missing lines Patch % Lines
...sources/status/GetCapabilitiesRemoteOperation.java 0.00% 7 Missing ⚠️
...cloud/android/lib/resources/status/OCCapability.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1665      +/-   ##
============================================
+ Coverage     22.69%   22.72%   +0.02%     
- Complexity      633      638       +5     
============================================
  Files           222      222              
  Lines          8407     8415       +8     
  Branches       1099     1102       +3     
============================================
+ Hits           1908     1912       +4     
- Misses         6305     6311       +6     
+ Partials        194      192       -2     
Files with missing lines Coverage Δ
...cloud/android/lib/resources/status/OCCapability.kt 93.15% <0.00%> (-1.30%) ⬇️
...sources/status/GetCapabilitiesRemoteOperation.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tighter integration on apps within Nextcloud ecosystem
2 participants